Summary

Add action renderers for sidebars.

Review Request #14716 — Created Nov. 28, 2025 and submitted Dec. 11, 2025, 4:29 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This introduces two new renderers used for sidebars: One for groups
(which recurses into subgroups), and one for items.

The renderers fit into the existing rb-c-sidebar styling. This has
been updated to support subgroups in the sidebar, which appear with a
bold (but not uppercase) header and nested items.

This in preparation for action registration for admin sidebar items,
which will allow extensions to augment the sidebar.

Testing Done

Unit tests pass.

Tested with an upcoming change converting the admin UI to the sidebar.

Commits

Summary	ID
Add action renderers for sidebars. This introduces two new renderers used for sidebars: One for groups (which recurses into subgroups), and one for items. The renderers fit into the existing `rb-c-sidebar` styling. This has been updated to support subgroups in the sidebar, which appear with a bold (but not uppercase) header and nested items. This in preparation for action registration for admin sidebar items, which will allow extensions to augment the sidebar.	4c82f5afa2bae7451bc42ddc64462ed237cfe814

Summary

Add action renderers for sidebars.

This introduces two new renderers used for sidebars: One for groups (which recurses into subgroups), and one for items. The renderers fit into the existing `rb-c-sidebar` styling. This has been updated to support subgroups in the sidebar, which appear with a bold (but not uppercase) header and nested items. This in preparation for action registration for admin sidebar items, which will allow extensions to augment the sidebar.

4c82f5afa2bae7451bc42ddc64462ed237cfe814

Files

Issues

Description	From	Last Updated
Can we add a test to verify that this URL matching works as expected?	david	Dec. 10, 2025, 12:08 a.m.
Can we prefix these with _ to mark them as internal? Otherwise future linting will complain about missing docstrings. (and/or …	david	Dec. 10, 2025, 12:11 a.m.
group_action.html defines this as already including {{action_attrs}}. From the unit tests it seems like this starts out empty, but it …	david	Dec. 10, 2025, 12:15 a.m.
This should be aria-labelledby (no second hyphen)	david	Dec. 10, 2025, 12:12 a.m.

flake8 passed.

JSHint passed.

reviewboard/actions/renderers.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we add a test to verify that this URL matching works as expected?
```

reviewboard/actions/tests/test_sidebar_action_group_renderer.py (Diff revision 1)

The issue has been resolved. Show all issues

Can we prefix these with _ to mark them as internal? Otherwise future linting will complain about missing docstrings.

(and/or we could add docstrings)

reviewboard/templates/actions/sidebar_group_action.html (Diff revision 1)

The issue has been dropped. Show all issues

group_action.html defines this as already including {{action_attrs}}. From the unit tests it seems like this starts out empty, but it seems like if anything is actually in there, by including both {{block.super}} and {{action_attrs}}, we'd get duplicate attributes (we actually might already with id=, and assertHTMLEqual's parsing is masking it).

chipx86 Dec. 10, 2025, 12:17 a.m.

That used to be the case, but the change for template cleanup changes this. Now that's separate by default, and the structure of sidebars necessitates combining the container and action attributes into one place. This was one of the reasons I put together that change before.

Testing this, we end up nuking id.

reviewboard/templates/actions/sidebar_group_action.html (Diff revision 1)
The issue has been resolved. Show all issues
```
This should be aria-labelledby (no second hyphen)
```

Change Summary:


Added a unit test to confirm the URL matching for active sidebar items.
Prefixed the internal test classes with _.
Fixed the aria-labelledby (it was being named aria-labelled-by).

Commits:

	Summary	ID
	Add action renderers for sidebars. This introduces two new renderers used for sidebars: One for groups (which recurses into subgroups), and one for items. The renderers fit into the existing `rb-c-sidebar` styling. This has been updated to support subgroups in the sidebar, which appear with a bold (but not uppercase) header and nested items. This in preparation for action registration for admin sidebar items, which will allow extensions to augment the sidebar.	ec50a6d498b8261721eb1bdcb873e6de54420672
	Add action renderers for sidebars. This introduces two new renderers used for sidebars: One for groups (which recurses into subgroups), and one for items. The renderers fit into the existing `rb-c-sidebar` styling. This has been updated to support subgroups in the sidebar, which appear with a bold (but not uppercase) header and nested items. This in preparation for action registration for admin sidebar items, which will allow extensions to augment the sidebar.	4c82f5afa2bae7451bc42ddc64462ed237cfe814

Diff:

Revision 2 (+956 -10)

Show changes

	reviewboard/actions/renderers.py
	reviewboard/actions/tests/test_sidebar_action_group_renderer.py
	reviewboard/actions/tests/test_sidebar_item_action_renderer.py
	reviewboard/static/rb/css/ui/sidebars.less
	reviewboard/templates/actions/sidebar_group_action.html
	reviewboard/templates/actions/sidebar_item_action.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (d5fc926)