Summary

Do some modernization in advance of binary file support for rbt patch.

Review Request #14713 — Created Nov. 28, 2025 and submitted Jan. 8, 2026, 8:53 a.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This change modernizes type annotations, syntax, and docs within the
patch command implementation, along with the rbtools.diffs.patches and
rbtools.diffs.patcher modules.

Testing Done

Ran unit tests.

Commits

Summary	ID
Do some modernization in advance of binary file support for rbt patch. This change modernizes type annotations, syntax, and docs within the patch command implementation, along with the `rbtools.diffs.patches` and `rbtools.diffs.patcher` modules. Testing Done: Ran unit tests.	nxupvqrnzspstmtuwqkmqnwqrylwwwxl

Issues

Description	From	Last Updated
Can you update this to str instead of unicode.	maubin	Dec. 30, 2025, 9:24 a.m.
review_request_id is None in this case. You should put options.args[0] here instead.	maubin	Jan. 7, 2026, 8:08 p.m.
This is old but is this right? Nothing gets passed to the placeholder.	maubin	Dec. 30, 2025, 9:24 a.m.
Let's stick to one keyword argument per line, keep it managable.	chipx86	Dec. 30, 2025, 9:24 a.m.
This needs to be updated to OSError	maubin	Dec. 30, 2025, 9:25 a.m.

flake8 passed.

JSHint passed.

rbtools/diffs/patcher.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Let's stick to one keyword argument per line, keep it managable.
```

rbtools/commands/patch.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can you update this to str instead of unicode.
```
rbtools/commands/patch.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This is old but is this right? Nothing gets passed to the placeholder.
```
rbtools/diffs/patches.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This needs to be updated to OSError
```

Commits:

	Summary	ID
	Do some modernization in advance of binary file support for rbt patch. This change modernizes type annotations, syntax, and docs within the patch command implementation, along with the `rbtools.diffs.patches` and `rbtools.diffs.patcher` modules. Testing Done: Ran unit tests.	nxupvqrnzspstmtuwqkmqnwqrylwwwxl
	Do some modernization in advance of binary file support for rbt patch. This change modernizes type annotations, syntax, and docs within the patch command implementation, along with the `rbtools.diffs.patches` and `rbtools.diffs.patcher` modules. Testing Done: Ran unit tests.	nxupvqrnzspstmtuwqkmqnwqrylwwwxl

Diff:

Revision 2 (+198 -394)

Show changes

	rbtools/commands/patch.py
	rbtools/diffs/patcher.py
	rbtools/diffs/patches.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/commands/patch.py (Diff revisions 1 - 2)

The issue has been resolved. Show all issues

review_request_id is None in this case. You should put options.args[0] here instead.

Commits:

	Summary	ID
	Do some modernization in advance of binary file support for rbt patch. This change modernizes type annotations, syntax, and docs within the patch command implementation, along with the `rbtools.diffs.patches` and `rbtools.diffs.patcher` modules. Testing Done: Ran unit tests.	nxupvqrnzspstmtuwqkmqnwqrylwwwxl
	Do some modernization in advance of binary file support for rbt patch. This change modernizes type annotations, syntax, and docs within the patch command implementation, along with the `rbtools.diffs.patches` and `rbtools.diffs.patcher` modules. Testing Done: Ran unit tests.	nxupvqrnzspstmtuwqkmqnwqrylwwwxl

Diff:

Revision 3 (+198 -394)

Show changes

	rbtools/commands/patch.py
	rbtools/diffs/patcher.py
	rbtools/diffs/patches.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (debf8cb)