Summary

Convert some review request dialogs to Ink.

Review Request #14691 — Created Nov. 14, 2025 and submitted Dec. 9, 2025, 11:48 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This updates the following dialogs to use the new Ink dialog
capabilities:

Publish error alerts
Ship It confirmation dialog
Prompt for loading a draft
Legacy closed Banner view's error handler.

Where appropriate, some of the containing functions have been made
async. This will be used along with upcoming changes for async actions.

Testing Done

Unit tests pass.

Tested each of these actions, verifying the dialogs worked as
expected and that Do Not Ask Again was respected.

Commits

Summary	ID
Convert some review request dialogs to Ink. This updates the following dialogs to use the new Ink dialog capabilities: * Publish error alerts * Ship It confirmation dialog * Prompt for loading a draft * Legacy closed Banner view's error handler. Where appropriate, some of the containing functions have been made async. This will be used along with upcoming changes for async actions.	31b90ad8c74e8d46a315dd0072c22a8a8e5461bb

Issues

Description	From	Last Updated
I like the description you used in the Ship it click handler, we should use it here: "This function is …	maubin	Nov. 28, 2025, 9:48 p.m.
It looks like we're only using cid once now. Can we just use this.cid inline?	david	Nov. 28, 2025, 9:48 p.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/reviews/views/reviewablePageView.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
It looks like we're only using cid once now. Can we just use this.cid inline?
```

reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts (Diff revision 1)

The issue has been resolved. Show all issues

I like the description you used in the Ship it click handler, we should use it here: "This function is now asynchronous, returning a Promise."
Also we should add a returns section to the docs.

Change Summary:


Removed an unnecessary local variable.
Improved docs for promptToLoadUserDraft and added a missing "Returns".

Commits:

	Summary	ID
	Convert some review request dialogs to Ink. This updates the following dialogs to use the new Ink dialog capabilities: * Publish error alerts * Ship It confirmation dialog * Prompt for loading a draft * Legacy closed Banner view's error handler. Where appropriate, some of the containing functions have been made async. This will be used along with upcoming changes for async actions.	f854f317a42af004a677733fc9968f6a237962e4
	Convert some review request dialogs to Ink. This updates the following dialogs to use the new Ink dialog capabilities: * Publish error alerts * Ship It confirmation dialog * Prompt for loading a draft * Legacy closed Banner view's error handler. Where appropriate, some of the containing functions have been made async. This will be used along with upcoming changes for async actions.	31b90ad8c74e8d46a315dd0072c22a8a8e5461bb

Diff:

Revision 2 (+282 -290)

Show changes

	reviewboard/static/rb/js/reviews/models/reviewRequestActionModels.ts
	reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts
	reviewboard/static/rb/js/reviews/views/reviewablePageView.ts
	reviewboard/static/rb/js/reviews/views/tests/reviewablePageViewTests.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (c01c7ed)