Summary

Fix fieldset classes for settings forms.

Review Request #14686 — Created Nov. 11, 2025 and submitted Dec. 9, 2025, 10:14 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

In admin model forms, the change_form_fieldsets templatetag will

instantiate an adapter object to convert django's builtin class names

(like 'wide') to our form CSS class names ('-is-wide').
For settings forms, the template doesn't (and really can't) use that

templatetag, since a settings form is different from an adminform. In

these cases we were still using the django class names, which resulted

in using 'wide' as the class name, which wasn't correct.
This change makes our djblets_forms fieldset template check for the

'wide' class, and add '-is-wide' if found.

Testing Done

Viewed settings forms in the admin and saw that fieldsets now had the

correct class name, and that we now had a match between the label widths

in regular fieldsets and in subforms (which go through slightly

different templates, ugh).

Commits

Summary	ID
Fix fieldset classes for settings forms. In admin model forms, the `change_form_fieldsets` templatetag will instantiate an adapter object to convert django's builtin class names (like 'wide') to our form CSS class names ('-is-wide'). For settings forms, the template doesn't (and really can't) use that templatetag, since a settings form is different from an adminform. In these cases we were still using the django class names, which resulted in using 'wide' as the class name, which wasn't correct. This change makes our djblets_forms fieldset template check for the 'wide' class, and add '-is-wide' if found. Testing Done: Viewed settings forms in the admin and saw that fieldsets now had the correct class name, and that we now had a match between the label widths in regular fieldsets and in subforms (which go through slightly different templates, ugh).	xrylqmynpopwlosysuypopzmunklpprx

Summary

Fix fieldset classes for settings forms.

In admin model forms, the `change_form_fieldsets` templatetag will instantiate an adapter object to convert django's builtin class names (like 'wide') to our form CSS class names ('-is-wide'). For settings forms, the template doesn't (and really can't) use that templatetag, since a settings form is different from an adminform. In these cases we were still using the django class names, which resulted in using 'wide' as the class name, which wasn't correct. This change makes our djblets_forms fieldset template check for the 'wide' class, and add '-is-wide' if found. Testing Done: Viewed settings forms in the admin and saw that fieldsets now had the correct class name, and that we now had a match between the label widths in regular fieldsets and in subforms (which go through slightly different templates, ugh).

xrylqmynpopwlosysuypopzmunklpprx

Issues

Description	From	Last Updated
I think this change is fine, but I also feel like it'd be nice if we just let wide stay …	chipx86	Nov. 17, 2025, 3:46 p.m.

flake8 passed.

JSHint passed.

The issue has been dropped. Show all issues

I think this change is fine, but I also feel like it'd be nice if we just let wide stay a valid value for these for consistency (sort of control mode for forms) and adapt it during render. That way settings forms and admin forms don't have to be different here. Is that doable?

david

Nov. 17, 2025, 3:28 p.m.

That would be a pretty big, invasive project. Settings forms themselves aren't necessarily always in the admin site, and the way templates inherit currently goes back and forth between the Djblets and Review Board codebases.

This is something I'd like to address in the new forms work instead.

chipx86

Nov. 25, 2025, 1:23 a.m.

Been thinking on this and poking at it, and I don't think it would. I do think it's worth keeping compatibility, because wide is basically at this point part of fieldset definition API.

Fieldset classes are controlled entirely by Review Board in reviewboard/templates/forms/fieldset.html, and this supports adding extra fieldsets.

That's inherited by reviewboard/templates/djblets_forms/admin/form_fieldset.html, which handles these admin fieldsets. This is all that's needed in that file to support this:

{% load djblets_utils %}

{% if fieldset.classes and fieldset.classes|contains:"wide" %}
{%  definevar "extra_fieldset_classes" %}{{extra_fieldset_classes}} -is-wide{% enddefinevar %}
{% endif %}


{% include "forms/fieldset.html" %}

There's no harm in leaving wide in there.

Ship it!

```
Ship It!
```

Description:

~		In admin model forms, the `change_form_fieldests` templatetag will
	~	In admin model forms, the `change_form_fieldsets` templatetag will
		instantiate an adapter object to convert django's builtin class names
		(like 'wide') to our form CSS class names ('-is-wide').

		For settings forms, the template doesn't (and really can't) use that
		templatetag, since a settings form is different from an adminform. In
~		these cases we still were using the django class names, which resulted
	~	these cases we were still using the django class names, which resulted
		in using 'wide' as the class name, which wasn't correct.

~		This change fixes up the settings forms to use the correct class name.
	~	This change makes our djblets_forms fieldset template check for the
	+	'wide' class, and add '-is-wide' if found.

Commits:

	Summary	ID
	Fix fieldset classes for settings forms. In admin model forms, the `change_form_fieldests` templatetag will instantiate an adapter object to convert django's builtin class names (like 'wide') to our form CSS class names ('-is-wide'). For settings forms, the template doesn't (and really can't) use that templatetag, since a settings form is different from an adminform. In these cases we still were using the django class names, which resulted in using 'wide' as the class name, which wasn't correct. This change fixes up the settings forms to use the correct class name. Testing Done: Viewed settings forms in the admin and saw that fieldsets now had the correct class name, and that we now had a match between the label widths in regular fieldsets and in subforms (which go through slightly different templates, ugh).	uzypmkmxpxqqrvtrqmpsouvmqskxnumy
	Fix fieldset classes for settings forms. In admin model forms, the `change_form_fieldsets` templatetag will instantiate an adapter object to convert django's builtin class names (like 'wide') to our form CSS class names ('-is-wide'). For settings forms, the template doesn't (and really can't) use that templatetag, since a settings form is different from an adminform. In these cases we were still using the django class names, which resulted in using 'wide' as the class name, which wasn't correct. This change makes our djblets_forms fieldset template check for the 'wide' class, and add '-is-wide' if found. Testing Done: Viewed settings forms in the admin and saw that fieldsets now had the correct class name, and that we now had a match between the label widths in regular fieldsets and in subforms (which go through slightly different templates, ugh).	xrylqmynpopwlosysuypopzmunklpprx

Diff:

Revision 2 (+12)

Show changes

reviewboard/templates/djblets_forms/admin/form_fieldset.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (3be3e63)