• 
      

    Organize children in grouped actions by attachment point ID.

    Review Request #14672 — Created Nov. 5, 2025 and submitted

    Information

    Review Board
    release-7.1.x

    Reviewers

    Now that actions can live in multiple attachment points, and may or may
    not have the same parent across them, we no longer want to represent
    only a single list of children.

    The children attribute for GroupAction is now a mapping of
    attachment point IDs to lists of children. This is set during render of
    the model. By grouping it this way, the action will factor in the
    correct children for a given group.

    This does not impact how actions are configured when defined. It's
    simply the representation to the rendering and view code.

    Unit tests pass.

    Tested that all menu actions contained the right children.

    Summary ID
    Organize children in grouped actions by attachment point ID.
    Now that actions can live in multiple attachment points, and may or may not have the same parent across them, we no longer want to represent only a single list of children. The `children` attribute for `GroupAction` is now a mapping of attachment point IDs to lists of children. This is set during render of the model. By grouping it this way, the action will factor in the correct children for a given group. This does not impact how actions are configured when defined. It's simply the representation to the rendering and view code.
    c3c9e3acf918163cd35ea098bac0e876967f00e3
    Description From Last Updated

    Mind adding a doc comment for this while you're here?

    david david
    maubin
    1. Ship It!
    2. 
        
    david
    1. 
        
    2. Show all issues

      Mind adding a doc comment for this while you're here?

    3. 
        
    chipx86
    maubin
    1. Ship It!
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-7.1.x (fa64489)