Organize children in grouped actions by attachment point ID.

 






 

 


  Review Request #14672
  —
  Created Nov. 5, 2025 and updated 

 




















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-7.1.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Now that actions can live in multiple attachment points, and may or may

not have the same parent across them, we no longer want to represent

only a single list of children.


The children attribute for GroupAction is now a mapping of

attachment point IDs to lists of children. This is set during render of

the model. By grouping it this way, the action will factor in the

correct children for a given group.


This does not impact how actions are configured when defined. It's

simply the representation to the rendering and view code.

 








  


 
 

  
Unit tests pass.


Tested that all menu actions contained the right children.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Organize children in grouped actions by attachment point ID.
      
Now that actions can live in multiple attachment points, and may or may
not have the same parent across them, we no longer want to represent
only a single list of children.

The `children` attribute for `GroupAction` is now a mapping of
attachment point IDs to lists of children. This is set during render of
the model. By grouping it this way, the action will factor in the
correct children for a given group.

This does not impact how actions are configured when defined. It's
simply the representation to the rendering and view code.

     


    		
    c3c9e3acf918163cd35ea098bac0e876967f00e3

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
Mind adding a doc comment for this while you're here?

      		
      
       daviddavid
      
      
       
      
     


    
   

  

 







 






  

 



















 




 




 














 





 

  

   




maubin




   

   







  

 



 

  


   

   

    
 
maubin



    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




david




   

   







  

 



 

  


   

   

    
 
david



    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/static/rb/js/common/actions/models/groupActionModel.ts
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Mind adding a doc comment for this while you're here?
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




chipx86




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  









  

   

    Change Summary:
   

   

    
    

  • Added a doc comment for the JS GroupAction.defaults().
    • 

  • Fixed typing of defaults().
    • 


   

  








  

   

    Commits:
   

   

    





 

  
   


    

    Summary
    ID

   

  
  

   


    

    

     

      Organize children in grouped actions by attachment point ID.
      
Now that actions can live in multiple attachment points, and may or may
not have the same parent across them, we no longer want to represent
only a single list of children.

The `children` attribute for `GroupAction` is now a mapping of
attachment point IDs to lists of children. This is set during render of
the model. By grouping it this way, the action will factor in the
correct children for a given group.

This does not impact how actions are configured when defined. It's
simply the representation to the rendering and view code.

     


    		
    032afbe4d428375e410a3e98e26e3fa8f893718f

   




   


    

    

     

      Organize children in grouped actions by attachment point ID.
      
Now that actions can live in multiple attachment points, and may or may
not have the same parent across them, we no longer want to represent
only a single list of children.

The `children` attribute for `GroupAction` is now a mapping of
attachment point IDs to lists of children. This is set during render of
the model. By grouping it this way, the action will factor in the
correct children for a given group.

This does not impact how actions are configured when defined. It's
simply the representation to the rendering and view code.

     


    		
    c3c9e3acf918163cd35ea098bac0e876967f00e3

   



  
 







   

  





  

   

    Diff:
   

   

    
 Revision 2 (+56 -24)
Show changes
 
    reviewboard/actions/base.py 
    reviewboard/actions/tests/test_group_action.py 
    reviewboard/static/rb/js/common/actions/models/groupActionModel.ts 
    reviewboard/static/rb/js/common/actions/views/menuActionView.ts 
 

   

  











 

  
Checks run (2 succeeded)



  

 flake8
 passed.
 





  

 JSHint
 passed.
 





 















  

 
















 





 

  

   




maubin




   

   







  

 



 

  


   

   

    
 
maubin



    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3.