-
-
-
rbtools/postreview.py (Diff revision 1) Can do: sep = "".ljust(...) Or: sep = 72 * options.commit_separator which should do the same thing.
-
rbtools/postreview.py (Diff revision 1) Would be nice to guard against the user having specified multiple characters.
-
postreview.py: add separator between commits
Review Request #1465 — Created March 8, 2010 and discarded
Information | |
---|---|
mw_triad | |
RBTools | |
Reviewers | |
rbtools | |
postreview.py: add separator between commits When posting a git / git-svn review with --guess-description, add a separator between commit logs. The separator is a 72-character line of a user-specified character. The default is empty.
posting this review request :-) (with no separator; also tested specifying separator with a git-svn repo, trying both single-commit and multiple-commit requests)
MW
Change Summary:
Update based on comments... need to find "post-review docs in the Review Board source tree" yet, but hopefully the .py is okay now. Thanks again for the feedback!
Diff: |
Revision 2 (+31 -10) |
---|
-
Looks good for the most part. Mind writing a unit test?
-
-
rbtools/postreview.py (Diff revision 2) Can you rename this to --git-commit-separator? Going to try to start prefixing parameters with their SCM until they're "promoted" to working with more.