Summary

Update typing for some of the extensions code.

Review Request #14633 — Created Oct. 8, 2025 and submitted Dec. 1, 2025, 3:18 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

This updates the typing for djblets.extensions.extension and
djblets.extensions.manager, moving to some modern typing constructs
and improving type safety for middleware.

This work is in preparation for some changes to ExtensionManager to
reduce side effects during reloading.

Testing Done

Unit tests pass.

Commits

Summary	ID
Update typing for some of the extensions code. This updates the typing for `djblets.extensions.extension` and `djblets.extensions.manager`, moving to some modern typing constructs and improving type safety for middleware. This work is in preparation for some changes to `ExtensionManager` to reduce side effects during reloading.	72b5a437c0c26a89201b481a149d8d7004859900

Issues

Description	From	Last Updated
Should we change this to be Mapping[str, Any]?	david	Nov. 28, 2025, 9:43 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Added some unstaged changes.

Commits:

	Summary	ID
	Update typing for some of the extensions code. This updates the typing for `djblets.extensions.extension` and `djblets.extensions.manager`, moving to some modern typing constructs and improving type safety for middleware. This work is in preparation for some changes to `ExtensionManager` to reduce side effects during reloading.	f899a1ff0f5eec2174acd3d418c1cf70dd0b521d
	Update typing for some of the extensions code. This updates the typing for `djblets.extensions.extension` and `djblets.extensions.manager`, moving to some modern typing constructs and improving type safety for middleware. This work is in preparation for some changes to `ExtensionManager` to reduce side effects during reloading.	a25ffce5cdfae7509d99f7cb49593929c5260cea

Diff:

Revision 2 (+218 -176)

Show changes

	djblets/extensions/extension.py
	djblets/extensions/manager.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

djblets/extensions/extension.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Should we change this to be Mapping[str, Any]?
```

Change Summary:

Switch ExtensionMetadata to be immutable, using Mapping.

Commits:

	Summary	ID
	Update typing for some of the extensions code. This updates the typing for `djblets.extensions.extension` and `djblets.extensions.manager`, moving to some modern typing constructs and improving type safety for middleware. This work is in preparation for some changes to `ExtensionManager` to reduce side effects during reloading.	a25ffce5cdfae7509d99f7cb49593929c5260cea
	Update typing for some of the extensions code. This updates the typing for `djblets.extensions.extension` and `djblets.extensions.manager`, moving to some modern typing constructs and improving type safety for middleware. This work is in preparation for some changes to `ExtensionManager` to reduce side effects during reloading.	3380a548a1eaa3ad6358efa74406158a7aeb942e

Diff:

Revision 3 (+228 -178)

Show changes

	djblets/extensions/extension.py
	djblets/extensions/manager.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Fixed the placement of an import.

Commits:

	Summary	ID
	Update typing for some of the extensions code. This updates the typing for `djblets.extensions.extension` and `djblets.extensions.manager`, moving to some modern typing constructs and improving type safety for middleware. This work is in preparation for some changes to `ExtensionManager` to reduce side effects during reloading.	3380a548a1eaa3ad6358efa74406158a7aeb942e
	Update typing for some of the extensions code. This updates the typing for `djblets.extensions.extension` and `djblets.extensions.manager`, moving to some modern typing constructs and improving type safety for middleware. This work is in preparation for some changes to `ExtensionManager` to reduce side effects during reloading.	72b5a437c0c26a89201b481a149d8d7004859900

Diff:

Revision 4 (+228 -178)

Show changes

	djblets/extensions/extension.py
	djblets/extensions/manager.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.x (103d731)