Summary

Update typing for some of the extensions code.

Review Request #14633 — Created Oct. 9, 2025 and updated Oct. 9, 2025, 2:41 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

This updates the typing for djblets.extensions.extension and
djblets.extensions.manager, moving to some modern typing constructs
and improving type safety for middleware.

This work is in preparation for some changes to ExtensionManager to
reduce side effects during reloading.

Testing Done

Unit tests pass.

Commits

Summary	ID
Update typing for some of the extensions code. This updates the typing for `djblets.extensions.extension` and `djblets.extensions.manager`, moving to some modern typing constructs and improving type safety for middleware. This work is in preparation for some changes to `ExtensionManager` to reduce side effects during reloading.	a25ffce5cdfae7509d99f7cb49593929c5260cea

Issues

Description	From	Last Updated
Should we change this to be Mapping[str, Any]?	david	Oct. 9, 2025, 2:41 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Added some unstaged changes.

Commits:

	Summary	ID
	Update typing for some of the extensions code. This updates the typing for `djblets.extensions.extension` and `djblets.extensions.manager`, moving to some modern typing constructs and improving type safety for middleware. This work is in preparation for some changes to `ExtensionManager` to reduce side effects during reloading.	f899a1ff0f5eec2174acd3d418c1cf70dd0b521d
	Update typing for some of the extensions code. This updates the typing for `djblets.extensions.extension` and `djblets.extensions.manager`, moving to some modern typing constructs and improving type safety for middleware. This work is in preparation for some changes to `ExtensionManager` to reduce side effects during reloading.	a25ffce5cdfae7509d99f7cb49593929c5260cea

Diff:

Revision 2 (+218 -176)

Show changes

	djblets/extensions/extension.py
	djblets/extensions/manager.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Fix it!

djblets/extensions/extension.py (Diff revision 2)
An issue was opened. Show all issues
```
Should we change this to be Mapping[str, Any]?
```