Summary

Fix quote types throughout Review Board.

Review Request #14608 — Created Sept. 11, 2025 and submitted March 12, 2026, 11:43 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change fixes up all the places where we have incorrect quote types
in the entire codebase.

Testing Done

Ran unit tests.

Commits

Summary	ID
Fix quote types throughout Review Board. This change fixes up all the places where we have incorrect quote types in the entire codebase. Testing Done: Ran unit tests.	qrlomospuluzrvuusyxwqnmqznpusrot

Issues

Description	From	Last Updated
expected 2 blank lines after class or function definition, found 1 Column: 1 Error code: E305	reviewbot	Sept. 11, 2025, 1:33 p.m.
The mixing of string types is pretty error-prone. I think for a given multi-line string, we should only use one …	chipx86	Jan. 15, 2026, 2:51 p.m.
While here, we should prefix with r.	chipx86	Jan. 15, 2026, 2:52 p.m.
Same note here.	chipx86	Jan. 15, 2026, 2:53 p.m.
Same note here.	chipx86	Jan. 15, 2026, 2:53 p.m.
Same note here.	chipx86	Jan. 15, 2026, 2:54 p.m.
Same note here.	chipx86	Jan. 15, 2026, 2:54 p.m.
Same note here.	chipx86	Jan. 15, 2026, 2:55 p.m.
Same note here and the other strings below.	chipx86	Jan. 15, 2026, 2:59 p.m.
Same note here and the other strings below.	chipx86	Jan. 15, 2026, 3:01 p.m.
Same note here.	chipx86	Jan. 15, 2026, 3:01 p.m.
Same note here.	chipx86	Jan. 15, 2026, 3:02 p.m.
Let's revert the backported haystack backends. It's not our code, they're forks of backends in the tree with fixes. We …	chipx86	Jan. 15, 2026, 2:50 p.m.
Same note about consistent quotes within one string. Here and below.	chipx86	Jan. 15, 2026, 3:03 p.m.
Seems like this one changed by accident. We should change it back to what you had before, outer 's and …	maubin	Feb. 25, 2026, 8:29 a.m.

flake8 failed.

JSHint passed.

flake8

contrib/internal/devserver.py (Diff revision 1)

The issue has been dropped. Show all issues

expected 2 blank lines after class or function definition, found 1

Column: 1
Error code: E305

Commits:

	Summary	ID
	Fix quote types throughout Review Board. This change fixes up all the places where we have incorrect quote types in the entire codebase. Testing Done: Ran unit tests.	qrlomospuluzrvuusyxwqnmqznpusrot
	Fix quote types throughout Review Board. This change fixes up all the places where we have incorrect quote types in the entire codebase. Testing Done: Ran unit tests.	qrlomospuluzrvuusyxwqnmqznpusrot

Diff:

Revision 2 (+2560 -2558)

Show changes

	contrib/internal/devserver.py
	contrib/internal/prepare-dev.py
	contrib/internal/run-pyflakes.py
	contrib/internal/test-upgrade.py
	contrib/profiling/gather_profile_stats.py
	contrib/profiling/print_info.py
	docs/codebase/conf.py
	docs/manual/conf.py
	92 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Fix quote types throughout Review Board. This change fixes up all the places where we have incorrect quote types in the entire codebase. Testing Done: Ran unit tests.	qrlomospuluzrvuusyxwqnmqznpusrot
	Fix quote types throughout Review Board. This change fixes up all the places where we have incorrect quote types in the entire codebase. Testing Done: Ran unit tests.	qrlomospuluzrvuusyxwqnmqznpusrot

Diff:

Revision 3 (+2560 -2558)

Show changes

	contrib/internal/devserver.py
	contrib/internal/prepare-dev.py
	contrib/internal/run-pyflakes.py
	contrib/internal/test-upgrade.py
	contrib/profiling/gather_profile_stats.py
	contrib/profiling/print_info.py
	docs/codebase/conf.py
	docs/manual/conf.py
	91 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Overall looks good, and I'm surprised we had so many inconsistent quotes!

I have two main things here, and I point out the important occurrences.

Mixing quote types within one wrapped string makes editing hard as escaped content wraps. We should be consistent within a string, even if we have to escape.
We have third-party forks in here that should be left upstream as much as possible. We should limit this work to our own code.

reviewboard/admin/forms/email_settings.py (Diff revision 3)

The issue has been resolved. Show all issues

The mixing of string types is pretty error-prone. I think for a given multi-line string, we should only use one type. Otherwise editing becomes more of a chore as we re-wrap strings and have to re-escape/re-quote.

reviewboard/admin/siteconfig.py (Diff revision 3)
The issue has been resolved. Show all issues
```
While here, we should prefix with r.
```
reviewboard/cmdline/rbsite.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Same note here.
```
reviewboard/cmdline/rbsite.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Same note here.
```
reviewboard/cmdline/rbsite.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Same note here.
```
reviewboard/cmdline/tests/test_rbsite.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Same note here.
```

reviewboard/datagrids/columns.py (Diff revision 3)

The issue has been dropped. Show all issues

Same note here.

david Jan. 15, 2026, 3:06 p.m.

These aren't wrapped strings, they're separate.

reviewboard/diffviewer/tests/test_diffutils.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Same note here and the other strings below.
```

reviewboard/diffviewer/tests/test_diffx_parser.py (Diff revision 3)

The issue has been resolved. Show all issues

Same note here and the other strings below.

reviewboard/reviews/tests/test_review_request_page_entry_registry.py (Diff revision 3)

The issue has been resolved. Show all issues

Same note here.

reviewboard/scmtools/tests/test_crypto_utils.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Same note here.
```

reviewboard/search/search_backends/haystack_backports/elasticsearch2_backend.py (Diff revision 3)

The issue has been resolved. Show all issues

Let's revert the backported haystack backends. It's not our code, they're forks of backends in the tree with fixes. We should keep them as similar as possible so the backported changes don't get lost in a sea of other changes.

reviewboard/webapi/resources/review_request.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Same note about consistent quotes within one string. Here and below.
```

Commits:

	Summary	ID
	Fix quote types throughout Review Board. This change fixes up all the places where we have incorrect quote types in the entire codebase. Testing Done: Ran unit tests.	qrlomospuluzrvuusyxwqnmqznpusrot
	Fix quote types throughout Review Board. This change fixes up all the places where we have incorrect quote types in the entire codebase. Testing Done: Ran unit tests.	qrlomospuluzrvuusyxwqnmqznpusrot

Diff:

Revision 4 (+1514 -1512)

Show changes

	contrib/internal/devserver.py
	contrib/internal/prepare-dev.py
	contrib/internal/run-pyflakes.py
	contrib/internal/test-upgrade.py
	contrib/profiling/gather_profile_stats.py
	contrib/profiling/print_info.py
	docs/codebase/conf.py
	docs/manual/conf.py
	84 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/wsgi.py (Diff revision 4)

The issue has been resolved. Show all issues

Seems like this one changed by accident. We should change it back to what you had before, outer 's and escape server\'s.

Commits:

	Summary	ID
	Fix quote types throughout Review Board. This change fixes up all the places where we have incorrect quote types in the entire codebase. Testing Done: Ran unit tests.	qrlomospuluzrvuusyxwqnmqznpusrot
	Fix quote types throughout Review Board. This change fixes up all the places where we have incorrect quote types in the entire codebase. Testing Done: Ran unit tests.	qrlomospuluzrvuusyxwqnmqznpusrot

Diff:

Revision 5 (+1452 -1452)

Show changes

	contrib/internal/devserver.py
	contrib/internal/prepare-dev.py
	contrib/internal/run-pyflakes.py
	contrib/internal/test-upgrade.py
	contrib/profiling/gather_profile_stats.py
	contrib/profiling/print_info.py
	docs/codebase/conf.py
	docs/manual/conf.py
	83 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (54b32f3)