Summary

Allow override_feature_check(s) to be used as decorators.

Review Request #14601 — Created Sept. 9, 2025 and submitted Sept. 9, 2025, 3:10 p.m.

Information

Owner

david

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Blocks

14602

Reviewers

Groups

djblets

People

Description

override_feature_check and override_feature_checks are two handy
methods that allow enabling or disabling features for unit testing.
Until now, they've been implemented solely as context managers. This
meant adding an additional layer of indentation for tests that needed to
wrap everything inside of them.

This change rewrites these two as classes which inherit from
django.test.utils.TestContextDecorator. This allows these to be used
either as a context manager or as a decorator.

Testing Done


Ran unit tests.
Used these in decorator form elsewhere.

Commits

Summary	ID
Allow override_feature_check(s) to be used as decorators. `override_feature_check` and `override_feature_checks` are two handy methods that allow enabling or disabling features for unit testing. Until now, they've been implemented solely as context managers. This meant adding an additional layer of indentation for tests that needed to wrap everything inside of them. This change rewrites these two as classes which inherit from `django.test.utils.TestContextDecorator`. This allows these to be used either as a context manager or as a decorator. Testing Done: - Ran unit tests. - Used these in decorator form elsewhere.	snnwlxqqnnskvxlxmumuquyorwuoquvu

Summary

Allow override_feature_check(s) to be used as decorators.

`override_feature_check` and `override_feature_checks` are two handy methods that allow enabling or disabling features for unit testing. Until now, they've been implemented solely as context managers. This meant adding an additional layer of indentation for tests that needed to wrap everything inside of them. This change rewrites these two as classes which inherit from `django.test.utils.TestContextDecorator`. This allows these to be used either as a context manager or as a decorator. Testing Done: - Ran unit tests. - Used these in decorator form elsewhere.

snnwlxqqnnskvxlxmumuquyorwuoquvu

Issues

Description	From	Last Updated
This needs to remain a Dict for this release.	chipx86	Sept. 9, 2025, 3:03 p.m.
No trailing period.	chipx86	Sept. 9, 2025, 3:06 p.m.
No trailing period.	chipx86	Sept. 9, 2025, 3:06 p.m.

flake8 passed.

JSHint passed.

djblets/features/testing.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This needs to remain a Dict for this release.
```
djblets/features/tests/test_testing.py (Diff revision 1)
The issue has been resolved. Show all issues
```
No trailing period.
```
djblets/features/tests/test_testing.py (Diff revision 1)
The issue has been resolved. Show all issues
```
No trailing period.
```

Commits:

	Summary	ID
	Allow override_feature_check(s) to be used as decorators. `override_feature_check` and `override_feature_checks` are two handy methods that allow enabling or disabling features for unit testing. Until now, they've been implemented solely as context managers. This meant adding an additional layer of indentation for tests that needed to wrap everything inside of them. This change rewrites these two as classes which inherit from `django.test.utils.TestContextDecorator`. This allows these to be used either as a context manager or as a decorator. Testing Done: - Ran unit tests. - Used these in decorator form elsewhere.	snnwlxqqnnskvxlxmumuquyorwuoquvu
	Allow override_feature_check(s) to be used as decorators. `override_feature_check` and `override_feature_checks` are two handy methods that allow enabling or disabling features for unit testing. Until now, they've been implemented solely as context managers. This meant adding an additional layer of indentation for tests that needed to wrap everything inside of them. This change rewrites these two as classes which inherit from `django.test.utils.TestContextDecorator`. This allows these to be used either as a context manager or as a decorator. Testing Done: - Ran unit tests. - Used these in decorator form elsewhere.	snnwlxqqnnskvxlxmumuquyorwuoquvu

Diff:

Revision 2 (+310 -144)

Show changes

	djblets/features/testing.py
	djblets/features/tests/test_testing.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.x (a507821)

djblets/features/testing.py (Diff revision 1)