SCM Path 256 -> 255

Review Request #1455 — Created March 5, 2010 and submitted

Information

Review Board

Reviewers

On MySQL, this creates an issue with unique=True. 

Rebuilding directory structure
Updating database. This may take a while.

Error: One or more models did not validate:
scmtools.repository: "path": CharField cannot have a "max_length" greater than 255 when using "unique=True".
Local dev server evolution.
chipx86
  1. Urgh. Great.
    
    Rather than updating an existing evolution file, you'll need to make a new one. Otherwise, any existing database that uses the max_length=256 will fail to update and django_evolution will get very confused.
    1. There was no evolution file yet in the tree... i'm not sure it made it to mainline
      
      http://github.com/reviewboard/reviewboard/tree/master/reviewboard/scmtools/evolutions/
      
    2. Gah. You're right, it never went in. In that case, looks good, committing :P
    3. Actually, sorry, the evolution file isn't quite correctly. It misses the raw URL field and the Mirror Path field, and should be using ChangeField. I'll just modify the evolution file I thought I committed though.
      
      When generating these, it's best to run:
      
      $ ./reviewboard/manage.py evolve --hint
    4. OK, do you need me to do anything?
      
    5. Nope, took care of it. Thanks :)
      
      We're going to need to add MySQL to our nightly tests at some point.
  2.