Summary

SCM Path 256 -> 255

Review Request #1455 — Created March 5, 2010 and submitted

Information

Owner

trimbo

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

On MySQL, this creates an issue with unique=True. 

Rebuilding directory structure
Updating database. This may take a while.

Error: One or more models did not validate:
scmtools.repository: "path": CharField cannot have a "max_length" greater than 255 when using "unique=True".

Testing Done

Local dev server evolution.

Urgh. Great.

Rather than updating an existing evolution file, you'll need to make a new one. Otherwise, any existing database that uses the max_length=256 will fail to update and django_evolution will get very confused.

trimbo March 5, 2010, 2:58 a.m.

There was no evolution file yet in the tree... i'm not sure it made it to mainline

http://github.com/reviewboard/reviewboard/tree/master/reviewboard/scmtools/evolutions/

chipx86 March 5, 2010, 3:02 a.m.

Gah. You're right, it never went in. In that case, looks good, committing :P

chipx86 March 5, 2010, 3:04 a.m.

Actually, sorry, the evolution file isn't quite correctly. It misses the raw URL field and the Mirror Path field, and should be using ChangeField. I'll just modify the evolution file I thought I committed though.

When generating these, it's best to run:

$ ./reviewboard/manage.py evolve --hint

TR

trimbo March 5, 2010, 3:05 a.m.
```
OK, do you need me to do anything?
```

chipx86 March 5, 2010, 3:08 a.m.

Nope, took care of it. Thanks :)

We're going to need to add MySQL to our nightly tests at some point.