Summary

Fix some typing around AppliesToURLMixin.

Review Request #14549 — Created Aug. 4, 2025 and submitted Aug. 6, 2025, 11:30 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

AppliesToURLMixin had the wrong base class, using Extension instead
of ExtensionHook, which ended up breaking the typing for
initialize() and other methods for anything subclassing a hook using
AppliesToURLMixin.

This fixes that, switches to Sequence[str] instead of List[str] for
the parameter, and adds typing for the attribute.

Testing Done

Unit tests pass.

Verified this fixed issues I hit with some extension work.

Commits

Summary	ID
Fix some typing around AppliesToURLMixin. `AppliesToURLMixin` had the wrong base class, using `Extension` instead of `ExtensionHook`, which ended up breaking the typing for `initialize()` and other methods for anything subclassing a hook using `AppliesToURLMixin`. This fixes that, switches to `Sequence[str]` instead of `List[str]` for the parameter, and adds typing for the attribute.	d3cd07b3a710309254e5ad776c5fdab52792f720

Issues

Description	From	Last Updated
While we're here, can we make this default to None and initialize to [] in the constructor?	david	Aug. 4, 2025, 5:32 p.m.

flake8 passed.

JSHint passed.

djblets/extensions/hooks.py (Diff revision 1)

The issue has been resolved. Show all issues

While we're here, can we make this default to None and initialize to [] in the constructor?

Change Summary:

Switched the default for apply_to to a non-mutable None.

Commits:

	Summary	ID
	Fix some typing around AppliesToURLMixin. `AppliesToURLMixin` had the wrong base class, using `Extension` instead of `ExtensionHook`, which ended up breaking the typing for `initialize()` and other methods for anything subclassing a hook using `AppliesToURLMixin`. This fixes that, switches to `Sequence[str]` instead of `List[str]` for the parameter, and adds typing for the attribute.	38d3962fb960b30cb2517567f28e907d2a14eeff
	Fix some typing around AppliesToURLMixin. `AppliesToURLMixin` had the wrong base class, using `Extension` instead of `ExtensionHook`, which ended up breaking the typing for `initialize()` and other methods for anything subclassing a hook using `AppliesToURLMixin`. This fixes that, switches to `Sequence[str]` instead of `List[str]` for the parameter, and adds typing for the attribute.	d3cd07b3a710309254e5ad776c5fdab52792f720

Diff:

Revision 2 (+20 -6)

Show changes

djblets/extensions/hooks.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.x (b25b7da)