Summary

Remove deprecated warning from SCMClient.has_dependencies.

Review Request #14487 — Created June 27, 2025 and submitted July 3, 2025, 11:01 a.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

The has_dependencies() method has for a while had an expect_checked
parameter which will skip setup in the case where we know that we've
already done it. This raised a deprecation warning about being removed
in RBTools 5, but we never did so. This change modifies the warning to
be an exception instead, and updates all the relevant test cases to
match.

Testing Done

Ran unit tests.

Commits

Summary	ID
Remove deprecated warning from SCMClient.has_dependencies. The `has_dependencies()` method has for a while had an `expect_checked` parameter which will skip setup in the case where we know that we've already done it. This raised a deprecation warning about being removed in RBTools 5, but we never did so. This change modifies the warning to be an exception instead, and updates all the relevant test cases to match. Testing Done: Ran unit tests.	ee51876b57d5c3cf17ef64369be31b2d31aa6497

Summary

Remove deprecated warning from SCMClient.has_dependencies.

The `has_dependencies()` method has for a while had an `expect_checked` parameter which will skip setup in the case where we know that we've already done it. This raised a deprecation warning about being removed in RBTools 5, but we never did so. This change modifies the warning to be an exception instead, and updates all the relevant test cases to match. Testing Done: Ran unit tests.

ee51876b57d5c3cf17ef64369be31b2d31aa6497

Issues

Description	From	Last Updated
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	June 27, 2025, 4:03 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/clients/tests/test_base_scmclient.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (80 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Remove deprecated warning from SCMClient.has_dependencies. The `has_dependencies()` method has for a while had an `expect_checked` parameter which will skip setup in the case where we know that we've already done it. This raised a deprecation warning about being removed in RBTools 5, but we never did so. This change modifies the warning to be an exception instead, and updates all the relevant test cases to match. Testing Done: Ran unit tests.	df7dbdc05d723bf5b6a55b974a1e4c5505703287
	Remove deprecated warning from SCMClient.has_dependencies. The `has_dependencies()` method has for a while had an `expect_checked` parameter which will skip setup in the case where we know that we've already done it. This raised a deprecation warning about being removed in RBTools 5, but we never did so. This change modifies the warning to be an exception instead, and updates all the relevant test cases to match. Testing Done: Ran unit tests.	ee51876b57d5c3cf17ef64369be31b2d31aa6497

Diff:

Revision 2 (+230 -594)

Show changes

	rbtools/clients/base/scmclient.py
	rbtools/clients/tests/test_base_scmclient.py
	rbtools/clients/tests/test_bzr.py
	rbtools/clients/tests/test_clearcase.py
	rbtools/clients/tests/test_cvs.py
	rbtools/clients/tests/test_git.py
	rbtools/clients/tests/test_mercurial.py
	rbtools/clients/tests/test_p4.py
	3 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed