Summary

Centralize the license providers used in unit tests.

Review Request #14469 — Created June 23, 2025 and updated June 24, 2025, 9:48 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Blocks

14470

Reviewers

Groups

reviewboard

People

Description

This moves the license providers built for the LicensesView unit tests
into a central module and documents them, in preparation for upcoming
unit tests that need to maintain the same behavior.

The classes are now named based on their purpose. License IDs are still
in license1 and license2 form just to keep things simple and
consistent for now.

Testing Done

Unit tests passed.

Tested with the upcoming changes introducing new suites of tests.

Commits

Summary	ID
Centralize the license providers used in unit tests. This moves the license providers built for the `LicensesView` unit tests into a central module and documents them, in preparation for upcoming unit tests that need to maintain the same behavior. The classes are now named based on their purpose. License IDs are still in `license1` and `license2` form just to keep things simple and consistent for now.	a823f5de87c619228aac35252063db712d28396c

Summary

Centralize the license providers used in unit tests.

This moves the license providers built for the `LicensesView` unit tests into a central module and documents them, in preparation for upcoming unit tests that need to maintain the same behavior. The classes are now named based on their purpose. License IDs are still in `license1` and `license2` form just to keep things simple and consistent for now.

a823f5de87c619228aac35252063db712d28396c

Issues

Description	From	Last Updated
'reviewboard.licensing.registry.LicenseProviderRegistry' imported but unused Column: 1 Error code: F401	reviewbot	June 23, 2025, 4:26 p.m.
'collections.abc.Iterable' imported but unused Column: 5 Error code: F401	reviewbot	June 23, 2025, 4:26 p.m.
Too many blank lines.	david	June 24, 2025, 9:48 a.m.
Can we put these in bullet points?	david	June 24, 2025, 9:48 a.m.
Can we alphabetize the keys?	david	June 24, 2025, 9:48 a.m.
Bullet points?	david	June 24, 2025, 9:48 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/licensing/tests/providers.py (Diff revision 1)

The issue has been resolved. Show all issues

'reviewboard.licensing.registry.LicenseProviderRegistry' imported but unused

Column: 1
Error code: F401

reviewboard/licensing/tests/providers.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'collections.abc.Iterable' imported but unused

Column: 5
Error code: F401
```

Change Summary:

Removed unused imports.

Commits:

	Summary	ID
	Centralize the license providers used in unit tests. This moves the license providers built for the `LicensesView` unit tests into a central module and documents them, in preparation for upcoming unit tests that need to maintain the same behavior. The classes are now named based on their purpose. License IDs are still in `license1` and `license2` form just to keep things simple and consistent for now.	c86bb6fe32d5039355ec2fd528c99a0ced45244e
	Centralize the license providers used in unit tests. This moves the license providers built for the `LicensesView` unit tests into a central module and documents them, in preparation for upcoming unit tests that need to maintain the same behavior. The classes are now named based on their purpose. License IDs are still in `license1` and `license2` form just to keep things simple and consistent for now.	a823f5de87c619228aac35252063db712d28396c

Diff:

Revision 2 (+678 -396)

Show changes

	reviewboard/licensing/tests/providers.py
	reviewboard/licensing/tests/test_licenses_view.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Fix it!

reviewboard/licensing/tests/providers.py (Diff revision 2)
An issue was opened. Show all issues
```
Too many blank lines.
```

reviewboard/licensing/tests/providers.py (Diff revision 2)

An issue was opened. Show all issues

Can we put these in bullet points?

reviewboard/licensing/tests/providers.py (Diff revision 2)
An issue was opened. Show all issues
```
Can we alphabetize the keys?
```
reviewboard/licensing/tests/providers.py (Diff revision 2)
An issue was opened. Show all issues
```
Bullet points?
```