Centralize the license providers used in unit tests.

Review Request #14469 — Created June 23, 2025 and submitted

Information

Review Board
release-7.1.x

Reviewers

This moves the license providers built for the LicensesView unit tests
into a central module and documents them, in preparation for upcoming
unit tests that need to maintain the same behavior.

The classes are now named based on their purpose. License IDs are still
in license1 and license2 form just to keep things simple and
consistent for now.

Unit tests passed.

Tested with the upcoming changes introducing new suites of tests.

Summary ID
Centralize the license providers used in unit tests.
This moves the license providers built for the `LicensesView` unit tests into a central module and documents them, in preparation for upcoming unit tests that need to maintain the same behavior. The classes are now named based on their purpose. License IDs are still in `license1` and `license2` form just to keep things simple and consistent for now.
26773394c19c957b80601ba700c0ab6857428293
Description From Last Updated

'reviewboard.licensing.registry.LicenseProviderRegistry' imported but unused Column: 1 Error code: F401

reviewbotreviewbot

'collections.abc.Iterable' imported but unused Column: 5 Error code: F401

reviewbotreviewbot

Too many blank lines.

daviddavid

Can we put these in bullet points?

daviddavid

Can we alphabetize the keys?

daviddavid

Bullet points?

daviddavid

This looks like it was meant for the get_check_license_request method below.

maubinmaubin

This is also not the right documentation for this method.

maubinmaubin
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
david
  1. 
      
  2. reviewboard/licensing/tests/providers.py (Diff revision 2)
     
     
     
    Show all issues

    Too many blank lines.

  3. reviewboard/licensing/tests/providers.py (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
    Show all issues

    Can we put these in bullet points?

  4. reviewboard/licensing/tests/providers.py (Diff revision 2)
     
     
     
     
     
     
    Show all issues

    Can we alphabetize the keys?

  5. reviewboard/licensing/tests/providers.py (Diff revision 2)
     
     
     
     
     
     
    Show all issues

    Bullet points?

  6. 
      
chipx86
david
  1. Ship It!
  2. 
      
maubin
  1. 
      
  2. reviewboard/licensing/tests/providers.py (Diff revision 3)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Show all issues

    This looks like it was meant for the get_check_license_request method below.

  3. reviewboard/licensing/tests/providers.py (Diff revision 3)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Show all issues

    This is also not the right documentation for this method.

  4. 
      
chipx86
maubin
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-7.1.x (859a23c)