Summary

Allow license providers to update/remove multiple licenses at once.

Review Request #14460 — Created June 18, 2025 and submitted Aug. 6, 2025, 3:19 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This enables a license provider to represent a main license with
multiple sub-licenses and then update or remove sub-licenses based on
the new license data, without having to do processing per-license.

To do this, the license provider's check license response now sets a
license_infos dictionary mapping license IDs to either payload data
(to add or update) or null (to remove). This is then handled on the
JavaScript side by updating all licenses from that provider that match
the ID.

Each license provider's set of licenses are managed client-side in a new
LicenseCollection, which performs those batch updates and also takes
care of performing a group of license update checks. These are now
checked sequentially instead of all at once.

Testing Done

Unit tests pass.

Tested this with the license support in Power Pack.

Commits

Summary	ID
Allow license providers to update/remove multiple licenses at once. The license update support is no longer limited to updating just the information for the license being checked. Now, a license provider can update the license information for multiple licenses at once when returning a license payload, and can also remove licenses. This enables a license provider to represent a main license with multiple sub-licenses and then update or remove sub-licenses based on the new license data, without having to do processing per-license. To do this, the license provider's check license response now sets a `license_infos` dictionary mapping license IDs to either payload data (to add or update) or `null` (to remove). This is then handled on the JavaScript side by updating all licenses from that provider that match the ID. Each license provider's set of licenses are managed client-side in a new `LicenseCollection`, which performs those batch updates and also takes care of performing a group of license update checks. These are now checked sequentially instead of all at once.	d59294bdc7adc23c3b4f9d6510fedc14b6485ad2

Summary

Allow license providers to update/remove multiple licenses at once.

The license update support is no longer limited to updating just the information for the license being checked. Now, a license provider can update the license information for multiple licenses at once when returning a license payload, and can also remove licenses. This enables a license provider to represent a main license with multiple sub-licenses and then update or remove sub-licenses based on the new license data, without having to do processing per-license. To do this, the license provider's check license response now sets a `license_infos` dictionary mapping license IDs to either payload data (to add or update) or `null` (to remove). This is then handled on the JavaScript side by updating all licenses from that provider that match the ID. Each license provider's set of licenses are managed client-side in a new `LicenseCollection`, which performs those batch updates and also takes care of performing a group of license update checks. These are now checked sequentially instead of all at once.

d59294bdc7adc23c3b4f9d6510fedc14b6485ad2

Issues

Description	From	Last Updated
'collections.abc.Sequence' imported but unused Column: 5 Error code: F401	reviewbot	June 18, 2025, 1:58 a.m.
I think this can be imported as type LicenseCheckStatus	david	July 29, 2025, 1:35 p.m.
This isn't used in this file.	david	July 29, 2025, 1:36 p.m.
Missing a trailing comma.	david	July 29, 2025, 1:36 p.m.
Missing a trailing comma.	david	July 29, 2025, 1:36 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/licensing/license_checks.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'collections.abc.Sequence' imported but unused

Column: 5
Error code: F401
```

Change Summary:

Removed an unused import.

Testing Done:

	+	Unit tests pass.
	+
	+	Tested this with the license support in Power Pack.

Commits:

	Summary	ID
	Allow license providers to update/remove multiple licenses at once. The license update support is no longer limited to updating just the information for the license being checked. Now, a license provider can update the license information for multiple licenses at once when returning a license payload, and can also remove licenses. This enables a license provider to represent a main license with multiple sub-licenses and then update or remove sub-licenses based on the new license data, without having to do processing per-license. To do this, the license provider's check license response now sets a `license_infos` dictionary mapping license IDs to either payload data (to add or update) or `null` (to remove). This is then handled on the JavaScript side by updating all licenses from that provider that match the ID. Each license provider's set of licenses are managed client-side in a new `LicenseCollection`, which performs those batch updates and also takes care of performing a group of license update checks. These are now checked sequentially instead of all at once.	27be2d022e9b3114bf2ac53ed231e6a197cb4d7b
	Allow license providers to update/remove multiple licenses at once. The license update support is no longer limited to updating just the information for the license being checked. Now, a license provider can update the license information for multiple licenses at once when returning a license payload, and can also remove licenses. This enables a license provider to represent a main license with multiple sub-licenses and then update or remove sub-licenses based on the new license data, without having to do processing per-license. To do this, the license provider's check license response now sets a `license_infos` dictionary mapping license IDs to either payload data (to add or update) or `null` (to remove). This is then handled on the JavaScript side by updating all licenses from that provider that match the ID. Each license provider's set of licenses are managed client-side in a new `LicenseCollection`, which performs those batch updates and also takes care of performing a group of license update checks. These are now checked sequentially instead of all at once.	5b4da72a37b80f3a78a46e3773f3797bcb463f30

Diff:

Revision 2 (+1248 -466)

Show changes

	reviewboard/licensing/license_checks.py
	reviewboard/licensing/views.py
	reviewboard/licensing/tests/test_licenses_view.py
	reviewboard/static/rb/js/admin/index.ts
	reviewboard/static/rb/js/admin/collections/licenseCollection.ts
	reviewboard/static/rb/js/admin/collections/tests/index.ts
	reviewboard/static/rb/js/admin/collections/tests/licenseCollectionTests.ts
	reviewboard/static/rb/js/admin/models/licenseModel.ts
	4 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/admin/collections/licenseCollection.ts (Diff revision 2)
The issue has been resolved. Show all issues
```
I think this can be imported as type LicenseCheckStatus
```
reviewboard/static/rb/js/admin/collections/tests/licenseCollectionTests.ts (Diff revision 2)
The issue has been dropped. Show all issues
```
This isn't used in this file.
```
1. chipx86 July 29, 2025, 1:37 p.m.
  This is used. Though if you meant CheckboxFieldView, that was not. IDE inserted it when trying to reference something.
reviewboard/templates/admin/licensing.html (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing a trailing comma.
```
reviewboard/templates/admin/licensing.html (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing a trailing comma.
```

Change Summary:


Removed an unused import.
Switch an import to a typing-only import.
Added some missing trailing commas.

Commits:

	Summary	ID
	Allow license providers to update/remove multiple licenses at once. The license update support is no longer limited to updating just the information for the license being checked. Now, a license provider can update the license information for multiple licenses at once when returning a license payload, and can also remove licenses. This enables a license provider to represent a main license with multiple sub-licenses and then update or remove sub-licenses based on the new license data, without having to do processing per-license. To do this, the license provider's check license response now sets a `license_infos` dictionary mapping license IDs to either payload data (to add or update) or `null` (to remove). This is then handled on the JavaScript side by updating all licenses from that provider that match the ID. Each license provider's set of licenses are managed client-side in a new `LicenseCollection`, which performs those batch updates and also takes care of performing a group of license update checks. These are now checked sequentially instead of all at once.	5b4da72a37b80f3a78a46e3773f3797bcb463f30
	Allow license providers to update/remove multiple licenses at once. The license update support is no longer limited to updating just the information for the license being checked. Now, a license provider can update the license information for multiple licenses at once when returning a license payload, and can also remove licenses. This enables a license provider to represent a main license with multiple sub-licenses and then update or remove sub-licenses based on the new license data, without having to do processing per-license. To do this, the license provider's check license response now sets a `license_infos` dictionary mapping license IDs to either payload data (to add or update) or `null` (to remove). This is then handled on the JavaScript side by updating all licenses from that provider that match the ID. Each license provider's set of licenses are managed client-side in a new `LicenseCollection`, which performs those batch updates and also takes care of performing a group of license update checks. These are now checked sequentially instead of all at once.	d59294bdc7adc23c3b4f9d6510fedc14b6485ad2

Diff:

Revision 3 (+1248 -468)

Show changes

	reviewboard/licensing/license_checks.py
	reviewboard/licensing/views.py
	reviewboard/licensing/tests/test_licenses_view.py
	reviewboard/static/rb/js/admin/index.ts
	reviewboard/static/rb/js/admin/collections/licenseCollection.ts
	reviewboard/static/rb/js/admin/collections/tests/index.ts
	reviewboard/static/rb/js/admin/collections/tests/licenseCollectionTests.ts
	reviewboard/static/rb/js/admin/models/licenseModel.ts
	4 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (a850f73)