Add LocalSite layer to diff settings.

 






 

 


  Review Request #14433
  —
  Created May 9, 2025 and updated 

 




















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-7.1.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change makes it so if a LocalSite's extra_data contains a

siteconfig key, we'll use it as an additional layer for diff settings.

This will allow those sites to override the global diff settings.

 








  


 
 

  
Ran unit tests.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Add LocalSite layer to diff settings.
      
This change makes it so if a LocalSite's extra_data contains a
`siteconfig` key, we'll use it as an additional layer for diff settings.
This will allow those sites to override the global diff settings.

Testing Done:
Ran unit tests.

     


    		
    f418b66e0ea1ef08133d3a7f511d628a450f09a1

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
Should use the formal name of "Local Sites".

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
Can we add a type for this?

      		
      
       chipx86chipx86
      
      
       
      
     


    
   

  

 







 






  

 



















 




 




 














 





 

  

   




maubin




   

   







  

 



 

  


   

   

    
 
maubin



    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86



    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/diffviewer/settings.py
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Should use the formal name of "Local Sites".
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/diffviewer/settings.py
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Can we add a type for this?
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  4. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  















  

   

    Commits:
   

   

    





 

  
   


    

    Summary
    ID

   

  
  

   


    

    

     

      Add LocalSite layer to diff settings.
      
This change makes it so if a LocalSite's extra_data contains a
`siteconfig` key, we'll use it as an additional layer for diff settings.
This will allow those sites to override the global diff settings.

Testing Done:
Ran unit tests.

     


    		
    60483b2aa9082c2623bb408cbdba6e304235e26f

   




   


    

    

     

      Add LocalSite layer to diff settings.
      
This change makes it so if a LocalSite's extra_data contains a
`siteconfig` key, we'll use it as an additional layer for diff settings.
This will allow those sites to override the global diff settings.

Testing Done:
Ran unit tests.

     


    		
    f418b66e0ea1ef08133d3a7f511d628a450f09a1

   



  
 







   

  





  

   

    Diff:
   

   

    
 Revision 2 (+120 -18)
Show changes
 
    reviewboard/diffviewer/settings.py 
    reviewboard/diffviewer/tests/test_diff_settings.py 
 

   

  











 

  
Checks run (2 succeeded)



  

 flake8
 passed.
 





  

 JSHint
 passed.