This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-7.1.x (4e4ec27)

Summary

Add LocalSite layer to diff settings.

Review Request #14433 — Created May 9, 2025 and submitted 2 weeks ago

Information

Owner

david*

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description*

This change makes it so if a LocalSite's extra_data contains a
siteconfig key, we'll use it as an additional layer for diff settings.
This will allow those sites to override the global diff settings.

Testing Done

Ran unit tests.

Commits

Summary	ID
Add LocalSite layer to diff settings. This change makes it so if a LocalSite's extra_data contains a `siteconfig` key, we'll use it as an additional layer for diff settings. This will allow those sites to override the global diff settings. Testing Done: Ran unit tests.	f418b66e0ea1ef08133d3a7f511d628a450f09a1

Issues

Description	From	Last Updated
Should use the formal name of "Local Sites".	chipx86	1 month, 1 week ago
Can we add a type for this?	chipx86	1 month, 1 week ago
There are no open issues

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/diffviewer/settings.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should use the formal name of "Local Sites".
```
reviewboard/diffviewer/settings.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we add a type for this?
```

Commits:

	Summary	ID
	Add LocalSite layer to diff settings. This change makes it so if a LocalSite's extra_data contains a `siteconfig` key, we'll use it as an additional layer for diff settings. This will allow those sites to override the global diff settings. Testing Done: Ran unit tests.	60483b2aa9082c2623bb408cbdba6e304235e26f
	Add LocalSite layer to diff settings. This change makes it so if a LocalSite's extra_data contains a `siteconfig` key, we'll use it as an additional layer for diff settings. This will allow those sites to override the global diff settings. Testing Done: Ran unit tests.	f418b66e0ea1ef08133d3a7f511d628a450f09a1

Diff:

Revision 2 (+120 -18)

Show changes

	reviewboard/diffviewer/settings.py
	reviewboard/diffviewer/tests/test_diff_settings.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (4e4ec27)