Summary

Prep work for diff settings layers.

Review Request #14432 — Created May 9, 2025 and updated May 15, 2025, 7:50 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change does some initial clean-up in preparation for implementing
settings layers in the diff settings object.

Testing Done

Ran unit tests.

Commits

Summary	ID
Prep work for diff settings layers. This change does some initial clean-up in preparation for implementing settings layers in the diff settings object. Testing Done: Ran unit tests.	75ce028ba10157b200886aa8c6941c8c3f21f4b7

Issues

Description	From	Last Updated
line too long (94 > 79 characters) Column: 80 Error code: E501	reviewbot	May 9, 2025, 3:19 p.m.
line too long (82 > 79 characters) Column: 80 Error code: E501	reviewbot	May 9, 2025, 3:19 p.m.
line too long (82 > 79 characters) Column: 80 Error code: E501	reviewbot	May 9, 2025, 3:19 p.m.
This doesn't need the parens.	maubin	May 12, 2025, 8:34 a.m.
Can you move some of these into the TYPE_CHECKING block.	maubin	May 12, 2025, 8:34 a.m.
Just checking - for casting we have to use Optional instead of \| None?	maubin	May 12, 2025, 8:34 a.m.
We can't use dict on RB 7.1.x. We still require 3.8+. Same below with other casts.	chipx86	May 15, 2025, 7:41 a.m.
We have to use Tuple here.	chipx86	May 15, 2025, 7:42 a.m.
We can't use this form on Python 3.8.	chipx86	May 15, 2025, 7:42 a.m.
We can't use these forms. Same below.	chipx86	May 15, 2025, 7:43 a.m.
'typing.TYPE_CHECKING' imported but unused Column: 1 Error code: F401	reviewbot	May 15, 2025, 7:44 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/diffviewer/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (94 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/diffviewer/tests/test_diff_settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (82 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/diffviewer/tests/test_diff_settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (82 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Prep work for diff settings layers. This change does some initial clean-up in preparation for implementing settings layers in the diff settings object. Testing Done: Ran unit tests.	4a8870177a405a3dbd60043d68623e9f9f2e1c0d
	Prep work for diff settings layers. This change does some initial clean-up in preparation for implementing settings layers in the diff settings object. Testing Done: Ran unit tests.	ec3f9471ae9771bbb7dba9ba740c4a57adaaa546

Diff:

Revision 2 (+182 -150)

Show changes

	reviewboard/admin/forms/diff_settings.py
	reviewboard/codesafety/checkers/base.py
	reviewboard/codesafety/checkers/trojan_source.py
	reviewboard/diffviewer/settings.py
	reviewboard/diffviewer/tests/test_diff_settings.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/codesafety/checkers/base.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This doesn't need the parens.
```
reviewboard/diffviewer/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Can you move some of these into the TYPE_CHECKING block.
```
1. david May 12, 2025, 8:35 a.m.
  Looks like no for all of these.

reviewboard/diffviewer/settings.py (Diff revision 2)

The issue has been dropped. Show all issues

Just checking - for casting we have to use Optional instead of | None?

david May 12, 2025, 8:35 a.m.

Yeah, X | Y at runtime only works for Python 3.10+

Commits:

	Summary	ID
	Prep work for diff settings layers. This change does some initial clean-up in preparation for implementing settings layers in the diff settings object. Testing Done: Ran unit tests.	ec3f9471ae9771bbb7dba9ba740c4a57adaaa546
	Prep work for diff settings layers. This change does some initial clean-up in preparation for implementing settings layers in the diff settings object. Testing Done: Ran unit tests.	95512112dbfefb65f82a9249649fa5141e034382

Diff:

Revision 3 (+182 -150)

Show changes

	reviewboard/admin/forms/diff_settings.py
	reviewboard/codesafety/checkers/base.py
	reviewboard/codesafety/checkers/trojan_source.py
	reviewboard/diffviewer/settings.py
	reviewboard/diffviewer/tests/test_diff_settings.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/admin/forms/diff_settings.py (Diff revision 3)

The issue has been resolved. Show all issues

We can't use dict on RB 7.1.x. We still require 3.8+.

Same below with other casts.

reviewboard/codesafety/checkers/trojan_source.py (Diff revision 3)
The issue has been resolved. Show all issues
```
We have to use Tuple here.
```
reviewboard/codesafety/checkers/trojan_source.py (Diff revision 3)
The issue has been resolved. Show all issues
```
We can't use this form on Python 3.8.
```
reviewboard/diffviewer/settings.py (Diff revision 3)
The issue has been resolved. Show all issues
```
We can't use these forms.
Same below.
```

Commits:

	Summary	ID
	Prep work for diff settings layers. This change does some initial clean-up in preparation for implementing settings layers in the diff settings object. Testing Done: Ran unit tests.	95512112dbfefb65f82a9249649fa5141e034382
	Prep work for diff settings layers. This change does some initial clean-up in preparation for implementing settings layers in the diff settings object. Testing Done: Ran unit tests.	e522c047a663af349c392692ef3d265d8ede2c84

Diff:

Revision 4 (+174 -146)

Show changes

	reviewboard/admin/forms/diff_settings.py
	reviewboard/codesafety/checkers/base.py
	reviewboard/codesafety/checkers/trojan_source.py
	reviewboard/diffviewer/settings.py
	reviewboard/diffviewer/tests/test_diff_settings.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/forms/diff_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
'typing.TYPE_CHECKING' imported but unused

Column: 1
Error code: F401
```

Commits:

	Summary	ID
	Prep work for diff settings layers. This change does some initial clean-up in preparation for implementing settings layers in the diff settings object. Testing Done: Ran unit tests.	e522c047a663af349c392692ef3d265d8ede2c84
	Prep work for diff settings layers. This change does some initial clean-up in preparation for implementing settings layers in the diff settings object. Testing Done: Ran unit tests.	cd40441b7b1e7bfe67ec0527691d4fe1c60cca4e

Diff:

Revision 5 (+174 -146)

Show changes

	reviewboard/admin/forms/diff_settings.py
	reviewboard/codesafety/checkers/base.py
	reviewboard/codesafety/checkers/trojan_source.py
	reviewboard/diffviewer/settings.py
	reviewboard/diffviewer/tests/test_diff_settings.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Prep work for diff settings layers. This change does some initial clean-up in preparation for implementing settings layers in the diff settings object. Testing Done: Ran unit tests.	cd40441b7b1e7bfe67ec0527691d4fe1c60cca4e
	Prep work for diff settings layers. This change does some initial clean-up in preparation for implementing settings layers in the diff settings object. Testing Done: Ran unit tests.	8ccd7ad0665d01f49fc254974c67fa7a5edfea74

Diff:

Revision 6 (+292 -162)

Show changes

	reviewboard/admin/forms/diff_settings.py
	reviewboard/codesafety/checkers/base.py
	reviewboard/codesafety/checkers/trojan_source.py
	reviewboard/diffviewer/settings.py
	reviewboard/diffviewer/tests/test_diff_settings.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Prep work for diff settings layers. This change does some initial clean-up in preparation for implementing settings layers in the diff settings object. Testing Done: Ran unit tests.	8ccd7ad0665d01f49fc254974c67fa7a5edfea74
	Prep work for diff settings layers. This change does some initial clean-up in preparation for implementing settings layers in the diff settings object. Testing Done: Ran unit tests.	75ce028ba10157b200886aa8c6941c8c3f21f4b7

Diff:

Revision 7 (+174 -146)

Show changes

	reviewboard/admin/forms/diff_settings.py
	reviewboard/codesafety/checkers/base.py
	reviewboard/codesafety/checkers/trojan_source.py
	reviewboard/diffviewer/settings.py
	reviewboard/diffviewer/tests/test_diff_settings.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.