Fix positioning of the action menus when off the side of the screen.

Review Request #14419 — Created May 2, 2025 and submitted

Information

Review Board
release-7.1.x

Reviewers

Actions menus that are near the right-hand side of the screen end up
being positioned too far to the right. This is easily seen with the
Follow menu. The logic, copied from Ink, was incorrect in its
calculations, and ended up off by the difference between the window
width and the right edge of the handle element.

It now attempts to more carefully place this on the screen without
scrolling off the side. First, it tries to right-align it to the parent
handle. If that's still off the side, then it tries to align it to the
right-most pixel of the window. And then, if we're off the left-hand
side, it tries to align to the left-most pixel of the window.

This logic will also be copied over to Ink.

Tested all the action menus I could find, and also tested with this
logic in Ink menus exhibiting the issue.

Summary ID
Fix positioning of the action menus when off the side of the screen.
Actions menus that are near the right-hand side of the screen end up being positioned too far to the right. This is easily seen with the Follow menu. The logic, copied from Ink, was incorrect in its calculations, and ended up off by the difference between the window width and the right edge of the handle element. It now attempts to more carefully place this on the screen without scrolling off the side. First, it tries to right-align it to the parent handle. If that's still off the side, then it tries to align it to the right-most pixel of the window. And then, if we're off the left-hand side, it tries to align to the left-most pixel of the window. This logic will also be copied over to Ink.
c1ca223b70afb61eed44fd84fb7698702c19a924

Description From Last Updated

We don't appear to be using this variable at all. Should you be reassigning to newMenuLeft at some point?

daviddavid
david
  1. 
      
  2. Show all issues

    We don't appear to be using this variable at all. Should you be reassigning to newMenuLeft at some point?

  3. 
      
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-7.1.x (3b29850)