Add typing and fixes for reviewboard.diffviewer.commit_utils.

Review Request #14416 — Created May 1, 2025 and updated — Latest diff uploaded

Information

Review Board
release-7.1.x

Reviewers

This fleshes out the remainder of reviewboard.diffviewer.commit_utils
with typing and documentation. The validation payloads are now fully
typed, which is only useful internally as this is considered opaque
outside this module.

There is one fix with equality checking for CommitHistoryDiffEntry. It
assumed the other type, and would crash if given a different type. We
now check for this.


 

Diff Revision 1 (Latest)

Commits

First Last Summary ID Author
Add typing and fixes for reviewboard.diffviewer.commit_utils.
This fleshes out the remainder of `reviewboard.diffviewer.commit_utils` with typing and documentation. The validation payloads are now fully typed, which is only useful internally as this is considered opaque outside this module. There is one fix with equality checking for `CommitHistoryDiffEntry`. It assumed the other type, and would crash if given a different type. We now check for this.
aa4db4eb9dc562eebb7d772b22fa2e8afae73bd2 Christian Hammond
reviewboard/diffviewer/commit_utils.py
Loading...