Add typing and fixes for reviewboard.diffviewer.commit_utils.

Review Request #14416 — Created May 1, 2025 and updated

Information

Review Board
release-7.1.x

Reviewers

This fleshes out the remainder of reviewboard.diffviewer.commit_utils
with typing and documentation. The validation payloads are now fully
typed, which is only useful internally as this is considered opaque
outside this module.

There is one fix with equality checking for CommitHistoryDiffEntry. It
assumed the other type, and would crash if given a different type. We
now check for this.


 
Summary ID
Add typing and fixes for reviewboard.diffviewer.commit_utils.
This fleshes out the remainder of `reviewboard.diffviewer.commit_utils` with typing and documentation. The validation payloads are now fully typed, which is only useful internally as this is considered opaque outside this module. There is one fix with equality checking for `CommitHistoryDiffEntry`. It assumed the other type, and would crash if given a different type. We now check for this.
aa4db4eb9dc562eebb7d772b22fa2e8afae73bd2
Description From Last Updated

'typing.Any' imported but unused Column: 5 Error code: F401

reviewbotreviewbot

Iterator should come from collections.abc

daviddavid
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
  1. 
      
  2. reviewboard/diffviewer/commit_utils.py (Diff revision 1)
     
     
    Show all issues

    Iterator should come from collections.abc

  3.