Make create_resource use keyword-only arguments.

 






 

 


  Review Request #14414
  —
  Created April 30, 2025 and updated 

 




















 

  

   Information

  





 
 

  david
 









 
 

  RBTools
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
The create_resource method recently gained an additional argument, and

it's getting unwieldy. This change makes it use keyword-only arguments

with appropriate deprecation.

 








  


 
 

  
Ran unit tests.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Make create_resource use keyword-only arguments.
      
The create_resource method recently gained an additional argument, and
it's getting unwieldy. This change makes it use keyword-only arguments
with appropriate deprecation.

Testing Done:
Ran unit tests.

     


    		
    2f4f9eaa4ca8545aac981d72faaf864f8950591a

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
Not necessary but since you're touching this, you could move the other typing imports under the if TYPE_CHECKING block to …

      		
      
       maubinmaubin
      
      
       
      
     


    
   

  

 







 






  

 



















 




 




 














 





 

  

   




maubin




   

   









  

 



 

  


   

   

    
 
maubin



    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       rbtools/api/tests/base.py
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Not necessary but since you're touching this, you could move the other typing imports under the if TYPE_CHECKING block to follow our new style.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  















  

   

    Commits:
   

   

    





 

  
   


    

    Summary
    ID

   

  
  

   


    

    

     

      Make create_resource use keyword-only arguments.
      
The create_resource method recently gained an additional argument, and
it's getting unwieldy. This change makes it use keyword-only arguments
with appropriate deprecation.

Testing Done:
Ran unit tests.

     


    		
    8983bfb969eb564c42f1efff98f8f75aa4967038

   




   


    

    

     

      Make create_resource use keyword-only arguments.
      
The create_resource method recently gained an additional argument, and
it's getting unwieldy. This change makes it use keyword-only arguments
with appropriate deprecation.

Testing Done:
Ran unit tests.

     


    		
    2f4f9eaa4ca8545aac981d72faaf864f8950591a

   



  
 







   

  





  

   

    Diff:
   

   

    
 Revision 2 (+342 -158)
Show changes
 
    rbtools/api/factory.py 
    rbtools/api/tests/base.py 
    rbtools/api/tests/test_factory.py 
    rbtools/api/tests/test_resource.py 
    rbtools/api/transport/sync.py 
 

   

  











 

  
Checks run (2 succeeded)



  

 flake8
 passed.
 





  

 JSHint
 passed.