This change has been marked as completed.

Describe the completed change (optional):

Pushed to master (fa08012)

Summary

Make create_resource use keyword-only arguments.

Review Request #14414 — Created April 30, 2025 and submitted 2 weeks, 1 day ago

Information

Owner

david*

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description*

The create_resource method recently gained an additional argument, and
it's getting unwieldy. This change makes it use keyword-only arguments
with appropriate deprecation.

Testing Done

Ran unit tests.

Commits

Summary	ID
Make create_resource use keyword-only arguments. The create_resource method recently gained an additional argument, and it's getting unwieldy. This change makes it use keyword-only arguments with appropriate deprecation. Testing Done: Ran unit tests.	bda92193e5bb5a27d64e6e56929f8e23a4a7c282

Issues

Description	From	Last Updated
Not necessary but since you're touching this, you could move the other typing imports under the if TYPE_CHECKING block to …	maubin	1 month, 3 weeks ago
Final should come before Optional	maubin	1 month ago
This is in the wrong import group.	chipx86	1 month ago
There are no open issues

flake8 passed.

JSHint passed.

Ship it!

rbtools/api/tests/base.py (Diff revision 1)

The issue has been resolved. Show all issues

Not necessary but since you're touching this, you could move the other typing imports under the if TYPE_CHECKING block to follow our new style.

Commits:

	Summary	ID
	Make create_resource use keyword-only arguments. The create_resource method recently gained an additional argument, and it's getting unwieldy. This change makes it use keyword-only arguments with appropriate deprecation. Testing Done: Ran unit tests.	8983bfb969eb564c42f1efff98f8f75aa4967038
	Make create_resource use keyword-only arguments. The create_resource method recently gained an additional argument, and it's getting unwieldy. This change makes it use keyword-only arguments with appropriate deprecation. Testing Done: Ran unit tests.	2f4f9eaa4ca8545aac981d72faaf864f8950591a

Diff:

Revision 2 (+342 -158)

Show changes

	rbtools/api/factory.py
	rbtools/api/tests/base.py
	rbtools/api/tests/test_factory.py
	rbtools/api/tests/test_resource.py
	rbtools/api/transport/sync.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

rbtools/api/tests/base.py (Diff revisions 1 - 2)
The issue has been resolved. Show all issues
```
Final should come before Optional
```

Commits:

	Summary	ID
	Make create_resource use keyword-only arguments. The create_resource method recently gained an additional argument, and it's getting unwieldy. This change makes it use keyword-only arguments with appropriate deprecation. Testing Done: Ran unit tests.	2f4f9eaa4ca8545aac981d72faaf864f8950591a
	Make create_resource use keyword-only arguments. The create_resource method recently gained an additional argument, and it's getting unwieldy. This change makes it use keyword-only arguments with appropriate deprecation. Testing Done: Ran unit tests.	bda92193e5bb5a27d64e6e56929f8e23a4a7c282

Diff:

Revision 3 (+342 -158)

Show changes

	rbtools/api/factory.py
	rbtools/api/tests/base.py
	rbtools/api/tests/test_factory.py
	rbtools/api/tests/test_resource.py
	rbtools/api/transport/sync.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

rbtools/api/factory.py (Diff revision 3)
The issue has been resolved. Show all issues
```
This is in the wrong import group.
```

Status:: Completed
Change Summary:: Pushed to master (fa08012)