Summary

Add an admin page for viewing and managing licenses.

Review Request #14404 — Created April 28, 2025 and updated April 29, 2025, 8:21 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

14401

Blocks

14405

Reviewers

Groups

reviewboard

People

Description

Each license is represented by a License model and LicenseView view,
backed by state provided by the License Provider. Custom models, views,
and data can be provided as needed.

Some basic infrastructure is set up for custom actions and license
checks. To ease review, those capabilities will be introduced in a
follow-up change.

Testing Done

Python and JavaScript unit tests passed.

Tested this with some custom License Providers registered in extensions
as tests, and with Power Pack ported over to License Providers. Verified
that all the state and status updates introduced in this change function
as expected.

Commits

Summary	ID
Add an admin page for viewing and managing licenses. This adds a new dedicated Licenses page in the Admin UI for seeing all current registered licenses across License Providers. These indicate the state of the licenses, expiration information, provide license management, actions, and custom line items. Each license is represented by a `License` model and `LicenseView` view, backed by state provided by the License Provider. Custom models, views, and data can be provided as needed. Some basic infrastructure is set up for custom actions and license checks. To ease review, those capabilities will be introduced in a follow-up change.	94a6067c0c98c25dd29cdc1e12649c75ab56826b

Summary

Add an admin page for viewing and managing licenses.

This adds a new dedicated Licenses page in the Admin UI for seeing all current registered licenses across License Providers. These indicate the state of the licenses, expiration information, provide license management, actions, and custom line items. Each license is represented by a `License` model and `LicenseView` view, backed by state provided by the License Provider. Custom models, views, and data can be provided as needed. Some basic infrastructure is set up for custom actions and license checks. To ease review, those capabilities will be introduced in a follow-up change.

94a6067c0c98c25dd29cdc1e12649c75ab56826b

Files

Issues

Description	From	Last Updated
'json' imported but unused Column: 1 Error code: F401	reviewbot	April 28, 2025, 1:50 p.m.
'uuid.uuid4' imported but unused Column: 1 Error code: F401	reviewbot	April 28, 2025, 1:50 p.m.
'reviewboard.licensing.errors.LicenseActionError' imported but unused Column: 1 Error code: F401	reviewbot	April 28, 2025, 1:50 p.m.
'reviewboard.licensing.license_checks.ProcessCheckLicenseResult' imported but unused Column: 1 Error code: F401	reviewbot	April 28, 2025, 1:50 p.m.
'reviewboard.licensing.license_checks.ProcessCheckLicenseResultStatus' imported but unused Column: 1 Error code: F401	reviewbot	April 28, 2025, 1:50 p.m.
'djblets.util.typing.JSONValue' imported but unused Column: 5 Error code: F401	reviewbot	April 28, 2025, 1:50 p.m.
'djblets.util.typing.SerializableJSONValue' imported but unused Column: 5 Error code: F401	reviewbot	April 28, 2025, 1:50 p.m.
Why are we doing it this way instead of include('reviewboard.licensing.urls')? Seems like we should stay consistent.	david	April 29, 2025, 8:21 a.m.
Should we define a TypedDict for this return type so we get warnings about if anything we're assigning isn't the …	david	April 29, 2025, 8:21 a.m.
Switch these two import lines	david	April 29, 2025, 8:21 a.m.
These should come from collections.abc, not typing	david	April 29, 2025, 8:21 a.m.
Can we either mark this as internal (prefix with _) or add docstrings to it? Future docstring linting will complain …	david	April 29, 2025, 8:21 a.m.
Same here.	david	April 29, 2025, 8:21 a.m.
And here.	david	April 29, 2025, 8:21 a.m.
Can we add doc comments on these?	david	April 29, 2025, 8:21 a.m.
Please add a docstring.	david	April 29, 2025, 8:21 a.m.
Please add a docstring.	david	April 29, 2025, 8:21 a.m.
Please add a docstring.	david	April 29, 2025, 8:21 a.m.
Please add a docstring.	david	April 29, 2025, 8:21 a.m.
tuple -> dict	david	April 29, 2025, 8:21 a.m.
This should fit on one line.	david	April 29, 2025, 8:21 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/licensing/tests/test_licenses_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'json' imported but unused

Column: 1
Error code: F401
```
reviewboard/licensing/tests/test_licenses_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'uuid.uuid4' imported but unused

Column: 1
Error code: F401
```
reviewboard/licensing/tests/test_licenses_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'reviewboard.licensing.errors.LicenseActionError' imported but unused

Column: 1
Error code: F401
```

reviewboard/licensing/tests/test_licenses_view.py (Diff revision 1)

The issue has been resolved. Show all issues

'reviewboard.licensing.license_checks.ProcessCheckLicenseResult' imported but unused

Column: 1
Error code: F401

reviewboard/licensing/tests/test_licenses_view.py (Diff revision 1)

The issue has been resolved. Show all issues

'reviewboard.licensing.license_checks.ProcessCheckLicenseResultStatus' imported but unused

Column: 1
Error code: F401

reviewboard/licensing/tests/test_licenses_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'djblets.util.typing.JSONValue' imported but unused

Column: 5
Error code: F401
```
reviewboard/licensing/tests/test_licenses_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'djblets.util.typing.SerializableJSONValue' imported but unused

Column: 5
Error code: F401
```

Change Summary:

Removed unused imports intended for the follow-up change.

Commits:

	Summary	ID
	Add an admin page for viewing and managing licenses. This adds a new dedicated Licenses page in the Admin UI for seeing all current registered licenses across License Providers. These indicate the state of the licenses, expiration information, provide license management, actions, and custom line items. Each license is represented by a `License` model and `LicenseView` view, backed by state provided by the License Provider. Custom models, views, and data can be provided as needed. Some basic infrastructure is set up for custom actions and license checks. To ease review, those capabilities will be introduced in a follow-up change.	dbc60a990cb29fad5e214c98abaa8b6977c7c0bf
	Add an admin page for viewing and managing licenses. This adds a new dedicated Licenses page in the Admin UI for seeing all current registered licenses across License Providers. These indicate the state of the licenses, expiration information, provide license management, actions, and custom line items. Each license is represented by a `License` model and `LicenseView` view, backed by state provided by the License Provider. Custom models, views, and data can be provided as needed. Some basic infrastructure is set up for custom actions and license checks. To ease review, those capabilities will be introduced in a follow-up change.	94a6067c0c98c25dd29cdc1e12649c75ab56826b

Diff:

Revision 2 (+4154 -16)

Show changes

	reviewboard/admin/urls.py
	reviewboard/licensing/provider.py
	reviewboard/licensing/urls.py
	reviewboard/licensing/views.py
	reviewboard/licensing/tests/test_licenses_view.py
	reviewboard/static/rb/css/bundles/admin.less
	reviewboard/static/rb/css/ui/admin/license.less
	reviewboard/static/rb/js/admin/index.ts
	8 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Fix it!

reviewboard/admin/urls.py (Diff revision 2)

An issue was opened. Show all issues

Why are we doing it this way instead of include('reviewboard.licensing.urls')? Seems like we should stay consistent.

reviewboard/licensing/provider.py (Diff revision 2)

An issue was opened. Show all issues

Should we define a TypedDict for this return type so we get warnings about if anything we're assigning isn't the right type?

reviewboard/licensing/tests/test_licenses_view.py (Diff revision 2)
An issue was opened. Show all issues
```
Switch these two import lines
```
reviewboard/licensing/tests/test_licenses_view.py (Diff revision 2)
An issue was opened. Show all issues
```
These should come from collections.abc, not typing
```

reviewboard/licensing/tests/test_licenses_view.py (Diff revision 2)

An issue was opened. Show all issues

Can we either mark this as internal (prefix with _) or add docstrings to it? Future docstring linting will complain otherwise.

reviewboard/licensing/tests/test_licenses_view.py (Diff revision 2)
An issue was opened. Show all issues
```
Same here.
```
reviewboard/licensing/tests/test_licenses_view.py (Diff revision 2)
An issue was opened. Show all issues
```
And here.
```
reviewboard/licensing/tests/test_licenses_view.py (Diff revision 2)
An issue was opened. Show all issues
```
Can we add doc comments on these?
```
reviewboard/licensing/tests/test_licenses_view.py (Diff revision 2)
An issue was opened. Show all issues
```
Please add a docstring.
```
reviewboard/licensing/tests/test_licenses_view.py (Diff revision 2)
An issue was opened. Show all issues
```
Please add a docstring.
```
reviewboard/licensing/tests/test_licenses_view.py (Diff revision 2)
An issue was opened. Show all issues
```
Please add a docstring.
```
reviewboard/licensing/tests/test_licenses_view.py (Diff revision 2)
An issue was opened. Show all issues
```
Please add a docstring.
```
reviewboard/licensing/views.py (Diff revision 2)
An issue was opened. Show all issues
```
tuple -> dict
```
reviewboard/static/rb/js/admin/views/licenseView.ts (Diff revision 2)
An issue was opened. Show all issues
```
This should fit on one line.
```