Update the fake hosting services mapping to use hosting service IDs.

 






 

 


  Review Request #14344
  —
  Created Feb. 13, 2025 and updated 

 




















 

  

   Information

  





 
 

  maubin
 









 
 

  Review Board
 









 
 

  release-7.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
The repository creation form advertises Power Pack's hosting services,

using fake versions of the hosting services for display. To do this, we

have a mapping of hosting service class paths to fake hosting services.


Power Pack 6 updates the class path for the Bitbucket Server hosting

service. This change updates the fake hosting services mapping to account

for this, otherwise a duplicate entry for Bitbucket Server would appear

in the hosting services choices when creating a repository. Instead of

using class paths in the mapping we use hosting service IDs, which will

show the right hosting services regardless of the Power Pack version,

and regardless of whether any more of their class paths change in the

future.

 








  


 
 

  
    

  • Ran unit tests.
    • 

  • Saw that there was no longer a duplicate entry in the hosting services
    
  choices.
    • 

  • Tested with Power Pack 5 and 6.
    • 


 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Update the fake hosting services mapping to use hosting service IDs.
      
The repository creation form advertises Power Pack's hosting services,
using fake versions of the hosting services for display. To do this, we
have a mapping of hosting service class paths to fake hosting services.

Power Pack 6 updates the class path for the Bitbucket Server hosting
service. This change updates the fake hosting services mapping to account
for this, otherwise a duplicate entry for Bitbucket Server would appear
in the hosting services choices when creating a repository. Instead of
using class paths in the mapping we use hosting service IDs, which will
show the right hosting services regardless of the Power Pack version,
and regardless of whether any more of their class paths change in the
future.

     


    		
    2db8b71ce80d3230e3b3c03bd1a3e1e1a9d82d54

   



  
 




 













 









 






  

 



















 




 




 














 





 

  

   




david




   

   





  

 



 

  


   

   

    
 
david



    
   


  

  

  



    




  1. 
 
    
  
    
   
    What happens if you have an older version of Power Pack installed?
    
  
    
 
    

 
    
  



 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




maubin




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  















  

   

    Summary:
   

   

    
Update the FakeBitbucketServerHostingService class path.
Update the fake hosting services mapping to use hosting service IDs.

   

  





  

   

    Description:
   

   

    
 ~   
This updates the path to Power Pack's Bitbucket Server hosting class
 ~   that is set in the FakeBitbucketServerHostingService. This path was
 ~   changed in Power Pack, so we need to update it here. Otherwise, a
 ~   duplicate entry for Bitbucket Server would appear in the hosting
 ~   services choices when creating a repository.
   ~ 
The repository creation form advertises Power Pack's hosting services,
   ~ using fake versions of the hosting services for display. To do this, we
   ~ have a mapping of hosting service class paths to fake hosting services.
   ~ 

   ~ 
Power Pack 6 updates the class path for the Bitbucket Server hosting
   + service. This change updates the fake hosting services mapping to account
   + for this, otherwise a duplicate entry for Bitbucket Server would appear
   + in the hosting services choices when creating a repository. Instead of
   + using class paths in the mapping we use hosting service IDs, which will
   + show the right hosting services regardless of the Power Pack version,
   + and regardless of whether any more of their class paths change in the
   + future.

   

  





  

   

    Testing Done:
   

   

    
     
  • Ran unit tests.
     
  • Saw that there was no longer a duplicate entry in the hosting services
    
  choices.
   + 
  • Tested with Power Pack 5 and 6.

   

  





  

   

    Commits:
   

   

    





 

  
   


    

    Summary
    ID

   

  
  

   


    

    

     

      Update the FakeBitbucketServerHostingService class path.
      
This updates the path to Power Pack's Bitbucket Server hosting class
that is set in the `FakeBitbucketServerHostingService`. This path was
changed in Power Pack, so we need to update it here. Otherwise, a
duplicate entry for Bitbucket Server would appear in the hosting
services choices when creating a repository.

     


    		
    2f62af3f4a32741eee32efd965ddfd8be79956b6

   




   


    

    

     

      Update the fake hosting services mapping to use hosting service IDs.
      
The repository creation form advertises Power Pack's hosting services,
using fake versions of the hosting services for display. To do this, we
have a mapping of hosting service class paths to fake hosting services.

Power Pack 6 updates the class path for the Bitbucket Server hosting
service. This change updates the fake hosting services mapping to account
for this, otherwise a duplicate entry for Bitbucket Server would appear
in the hosting services choices when creating a repository. Instead of
using class paths in the mapping we use hosting service IDs, which will
show the right hosting services regardless of the Power Pack version,
and regardless of whether any more of their class paths change in the
future.

     


    		
    2db8b71ce80d3230e3b3c03bd1a3e1e1a9d82d54

   



  
 







   

  





  

   

    Diff:
   

   

    
 Revision 2 (+18 -30)
Show changes
 
    reviewboard/hostingsvcs/fake.py 
    reviewboard/scmtools/forms.py 
 

   

  











 

  
Checks run (2 succeeded)



  

 flake8
 passed.
 





  

 JSHint
 passed.
 





 















  

 
















 





 

  

   




david




   

   







  

 



 

  


   

   

    
 
david



    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3.