Summary

Update Profile caching to use get_object_cached_field.

Review Request #14328 — Created Feb. 4, 2025 and submitted March 19, 2025, 7:29 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Djblets received a new function for fetching related objects from a

select_related() or prefetch_related() cache, which can simplify a

lot of code. One of the core tests for this was converting our somewhat

complex User.get_profile() cache logic to use that.
This change moves this method over to that, simplifying the function a

bit and helping ensure that functionality continues to work as expected.

Testing Done

Unit tests pass.

Commits

Summary	ID
Update Profile caching to use get_object_cached_field. Djblets received a new function for fetching related objects from a `select_related()` or `prefetch_related()` cache, which can simplify a lot of code. One of the core tests for this was converting our somewhat complex `User.get_profile()` cache logic to use that. This change moves this method over to that, simplifying the function a bit and helping ensure that functionality continues to work as expected.	fe05a0110f55765a82e7b2ff59aa0a13d27515a1

Summary

Update Profile caching to use get_object_cached_field.

Djblets received a new function for fetching related objects from a `select_related()` or `prefetch_related()` cache, which can simplify a lot of code. One of the core tests for this was converting our somewhat complex `User.get_profile()` cache logic to use that. This change moves this method over to that, simplifying the function a bit and helping ensure that functionality continues to work as expected.

fe05a0110f55765a82e7b2ff59aa0a13d27515a1

Issues

Description	From	Last Updated
'djblets.util.symbols.Unsettable' imported but unused Column: 5 Error code: F401	reviewbot	Feb. 4, 2025, 11:15 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/accounts/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'djblets.util.symbols.Unsettable' imported but unused

Column: 5
Error code: F401
```

Change Summary:

Removed an unused import.

Commits:

	Summary	ID
	Update Profile caching to use get_object_cached_field. Djblets received a new function for fetching related objects from a `select_related()` or `prefetch_related()` cache, which can simplify a lot of code. One of the core tests for this was converting our somewhat complex `User.get_profile()` cache logic to use that. This change moves this method over to that, simplifying the function a bit and helping ensure that functionality continues to work as expected.	3c0e7a296e08331311e9b785e159cbe9eec7a832
	Update Profile caching to use get_object_cached_field. Djblets received a new function for fetching related objects from a `select_related()` or `prefetch_related()` cache, which can simplify a lot of code. One of the core tests for this was converting our somewhat complex `User.get_profile()` cache logic to use that. This change moves this method over to that, simplifying the function a bit and helping ensure that functionality continues to work as expected.	fe05a0110f55765a82e7b2ff59aa0a13d27515a1

Diff:

Revision 2 (+48 -46)

Show changes

reviewboard/accounts/models.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (a77fca3)