Update typing and other modernization in git client.
Review Request #14324 — Created Feb. 3, 2025 and updated
This change does some improvements to our type hints, fixes up some doc
typos/errors, and moves to more modern syntax for a few things
(f-strings, list construction, etc).
Ran unit tests.
Summary | ID |
---|---|
5457bdd03805fe4fca704737365ddbad65c0b24b |
Description | From | Last Updated |
---|---|---|
At this point it'd be nice to just wrap these as a typical multi-line list with one item per line. … |
|
|
Instead of casting (here and below), we should probably assert. |
|
|
Instead of a cast, let's assert instead. |
|
|
For here and other messages, I think the right move is to keep these as-is and start wrapping in gettext. … |
|
|
Small thing, but when just consuming, we should use Sequence. |
|
|
Can you put these in alphabetical order? |
|
-
-
At this point it'd be nice to just wrap these as a typical multi-line list with one item per line.
We should probably also type as
ClassVar[Sequence[str]]
-
-
-
For here and other messages, I think the right move is to keep these as-is and start wrapping in
gettext
. The newer bits of code (Patcher, Patch, soem errors, a couple SCMs) are using gettext. -
-
- Commits:
-
Summary ID 5a94a36e4846bf02894202f95ffb8f1d7606d564 5457bdd03805fe4fca704737365ddbad65c0b24b - Diff:
-
Revision 2 (+938 -562)