Fix signature of SCMClient.amend_commit_description.

Review Request #14322 — Created Feb. 3, 2025 and submitted

Information

RBTools
master

Reviewers

The signature of the base SCMClient.amend_commit_description method
has the revisions parameter as keyword-only. Unfortunately, subclasses
that implement this method do not, and the stamp method does not invoke
it as such. This change fixes the base class so any future implementors
do not mistakenly copy that and then have rbt stamp or rbt post -s
crash.

Ran unit tests.

Summary ID
Fix signature of SCMClient.amend_commit_description.
The signature of the base `SCMClient.amend_commit_description` method has the `revisions` parameter as keyword-only. Unfortunately, subclasses that implement this method do not, and the stamp method does not invoke it as such. This change fixes the base class so any future implementors do not mistakenly copy that and then have `rbt stamp` or `rbt post -s` crash. Testing Done: Ran unit tests.
fbc48e7db825ee49da3ae6aa4adcc7aa2f4f7897
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to master (83626ef)