• 
      

    Add unit tests for the review request view.

    Review Request #14314 — Created Jan. 30, 2025 and submitted — Latest diff uploaded

    Information

    Review Board
    release-7.1.x

    Reviewers

    A recent change introduced unit tests for ReviewRequestPageData, which
    backs the review request page. This change fleshes out our testing
    further, adding tests for the view, which encompasses all the stages of
    ReviewRequestPageData along with other page components (actions,
    JavaScript setup, etc.).

    Review requests bound to repositories now use hosting services, which
    ensures a bit more test coverage (and unveils issues surrounding
    re-querying of repositories and other objects).

    This gives a more comprehensive view of where database queries need to
    be optimized.

    Unit tests pass.

    Commits

    Files