Summary

Add expected query assertions for the ReviewRequestPageData tests.

Review Request #14312 — Created Jan. 29, 2025 and submitted March 20, 2025, 2:21 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Blocks

14313

Reviewers

Groups

reviewboard

People

Description

In preparation for optimization work on ReviewRequestPageData, this
change fleshes out the current test suite with query assertion checks,
and adds some new tests and testing functionality.

Review requests bound to repositories now use hosting services, which
ensures a bit more test coverage (and unveils issues surrounding
re-querying of repositories and other objects).

This will give us a good foundation for seeing some of the effects of
upcoming optimizations.

Testing Done

Unit tests pass.

Commits

Summary	ID
Add expected query assertions for the ReviewRequestPageData tests. In preparation for optimization work on `ReviewRequestPageData`, this change fleshes out the current test suite with query assertion checks, and adds some new tests and testing functionality. Review requests bound to repositories now use hosting services, which ensures a bit more test coverage (and unveils issues surrounding re-querying of repositories and other objects). This will give us a good foundation for seeing some of the effects of upcoming optimizations.	01588a844db5fb0e7c8c18cc857c70811638fdf7

Summary

Add expected query assertions for the ReviewRequestPageData tests.

In preparation for optimization work on `ReviewRequestPageData`, this change fleshes out the current test suite with query assertion checks, and adds some new tests and testing functionality. Review requests bound to repositories now use hosting services, which ensures a bit more test coverage (and unveils issues surrounding re-querying of repositories and other objects). This will give us a good foundation for seeing some of the effects of upcoming optimizations.

01588a844db5fb0e7c8c18cc857c70811638fdf7

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Change Summary:

Updated repository-bound review requests in the tests to use hosting services, catching additional query issues.

Description:

		In preparation for optimization work on `ReviewRequestPageData`, this
		change fleshes out the current test suite with query assertion checks,
~		and adds some new tests and testing functionality. This will give us a
~		good foundation for seeing some of the effects of upcoming
~		optimizations.
	~	and adds some new tests and testing functionality.
	~
	~	Review requests bound to repositories now use hosting services, which
	+	ensures a bit more test coverage (and unveils issues surrounding
	+	re-querying of repositories and other objects).
	+
	+	This will give us a good foundation for seeing some of the effects of
	+	upcoming optimizations.

Commits:

	Summary	ID
	Add expected query assertions for the ReviewRequestPageData tests. In preparation for optimization work on `ReviewRequestPageData`, this change fleshes out the current test suite with query assertion checks, and adds some new tests and testing functionality. This will give us a good foundation for seeing some of the effects of upcoming optimizations.	b9ecb8e8a944cd359333de8ea234da1027c0827a
	Add expected query assertions for the ReviewRequestPageData tests. In preparation for optimization work on `ReviewRequestPageData`, this change fleshes out the current test suite with query assertion checks, and adds some new tests and testing functionality. Review requests bound to repositories now use hosting services, which ensures a bit more test coverage (and unveils issues surrounding re-querying of repositories and other objects). This will give us a good foundation for seeing some of the effects of upcoming optimizations.	01588a844db5fb0e7c8c18cc857c70811638fdf7

Diff:

Revision 2 (+4192 -372)

Show changes

reviewboard/reviews/tests/test_review_request_page_data.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (605a0bd)