Fix regressions in some tests introduced in User Details support.

Review Request #14295 — Created Jan. 16, 2025 and updated

Information

Review Board
release-7.1.x

Reviewers

As the User Details support evolved, some unit tests regressed. We were
making assumptions that HttpRequest.local_site would exist, and this
isn't always the case in unit tests. Some tests also weren't updated for
the new get_user_badges() signature.

This change updates the logic to conditionally fetch this information
and to update unit tests for the modern function signature.

All unit tests pass.

Summary ID
Fix regressions in some tests introduced in User Details support.
As the User Details support evolved, some unit tests regressed. We were making assumptions that `HttpRequest.local_site` would exist, and this isn't always the case in unit tests. Some tests also weren't updated for the new `get_user_badges()` signature. This change updates the logic to conditionally fetch this information and to update unit tests for the modern function signature.
386a7bb71b7fc5e1dd529a6c246bdd916f6db209
Checks run (2 succeeded)
flake8 passed.
JSHint passed.
david
  1. Ship It!
  2. 
      
maubin
  1. Ship It!
  2.