flake8
passed.
JSHint
passed.
Switch entry, review, and comment header styling to Flexbox.
Review Request #14285 — Created Jan. 2, 2025 and submitted
The styling for review request entries (reviews, etc.) and comment
headers now use Flexbox, which helps us manage styles more consistently
and avoids some hacks and workarounds to get things to line up in mobile
and desktop modes correctly.This is necessary for some in-progress work on user badges, which impact
the layout of this area.
Tested the styling for reviews, changes, and status updates, in both
expanded and collapsed mode.Tested these on both mobile and desktop at various widths.
Tested with in-progress changes for user badges.
Checked alignment on the text to make sure everything lined up
correctly.
| Summary | ID |
|---|---|
| 57e582068f5697e52ad715b4d14cbb3a4f6b818f |
| Description | From | Last Updated |
|---|---|---|
|
Can you switch this to #rb-ns-pages.base.on-shell-mobile-mode since .on-mobile-medium-screen-720 is deprecated? Or you can do #rb-ns-ui.screen.on-width-lte(720px, ...) if this really depends … |
 maubin
|
- Change Summary:
-
Tweaked spacing just a bit to give some breathing room when badges are added.
- Commits:
-
Summary ID bc7c6dde755a03bf0c8d7916c44caed7d9063265 19661a79685222d8527b2880e51eaa1abfd4c09b - Diff:
-
Revision 2 (+42 -34)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
Updated to use
#rb-ns-pages.base.on-shell-mobile-mode. - Commits:
-
Summary ID 19661a79685222d8527b2880e51eaa1abfd4c09b 57e582068f5697e52ad715b4d14cbb3a4f6b818f - Diff:
-
Revision 3 (+42 -34)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
