• 
      

    Fix scrolling the list of other comments in the comment dialog.

    Review Request #14277 — Created Dec. 18, 2024 and submitted

    Information

    Review Board
    release-7.x

    Reviewers

    When we implemented the fix to help keep the comment dialog from
    scrolling out of bounds when attempting to scroll part of the comment
    dialog's UI, we only enabled scrolling for the text area. Attempting to
    scroll the list of other comments on a line no longer worked, as the
    event would get swallowed.

    We now make an exception for this part of the UI, allowing it to scroll
    just like the text area.

    Verified I could scroll both the text area and the list of other comments,
    but otherwise scroll events did not bubble up to the page.

    Summary ID
    Fix scrolling the list of other comments in the comment dialog.
    When we implemented the fix to help keep the comment dialog from scrolling out of bounds when attempting to scroll part of the comment dialog's UI, we only enabled scrolling for the text area. Attempting to scroll the list of other comments on a line no longer worked, as the event would get swallowed. We now make an exception for this part of the UI, allowing it to scroll just like the text area.
    01e305b4420f2374a21336466e257c931310c37d
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-7.x (1eda265)