Add --no-build-isolation to development `pip install` commands.

 






 

 


  Review Request #14261
  —
  Created Dec. 4, 2024 and updated 

 




















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-7.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
When rebuilding my virtualenvs, modern pip causes setup.py develop to

break. While we eventually are going to transition away from setup.py

for Review Board, for the moment we still need it.


This change adds --no-build-isolation to our pip install commands

run by setup.py.

 








  


 
 

  
Was able to create my new envs.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Add --no-build-isolation to development `pip install` commands.
      
When rebuilding my virtualenvs, modern pip causes `setup.py develop` to
break. While we eventually are going to transition away from setup.py
for Review Board, for the moment we still need it.

This change adds `--no-build-isolation` to our `pip install` commands
run by setup.py.

Testing Done:
Was able to create my new envs.

     


    		
    3eb894ce7aaa4fd44fb85c61e6c43903edc1268b

   



  
 




 













 









 






  

 



















 




 

  


   

   

    
 
Checks run (2 succeeded)


    
   


  

  

  





 

 flake8
 passed.
 





 

 JSHint
 passed.
 
















  

 





 














 





 

  

   




chipx86




   

   





  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    We had previously landed this exact change to the file, and had to revoke it. It does more harm than good. In particular, it breaks Haystack entirely, and anything else depending on setuptools-scm.
    

    This commit was the attempt to get what we need: 5a19c96eabd577014c3ad148557bb667b1100873
    

    Let's go over what broke on your system and how we can tie it in to this.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I do have a bunch of work toward moving entirely to pyproject.toml, but I need to circle back to it and verify the resulting builds are completely correct. It's sitting in my tree right now.
      
 
      

      2. 


 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3.