Don't query terminal colors if we're disabling color support.

 






 

 


  Review Request #14250
  —
  Created Nov. 15, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  rbinstall
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
When starting up, we check the terminal background for light or dark

colors. This happens even if we've set no-color mode. That goes against

the intent of the workaround for terminal issues.


We no longer perform this check if color isn't allowed.

 








  


 
 

  
Ran in no-color mode and verified that a terminal query was never

performed.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Don't query terminal colors if we're disabling color support.
     
When starting up, we check the terminal background for light or dark
colors. This happens even if we've set no-color mode. That goes against
the intent of the workaround for terminal issues.

We no longer perform this check if color isn't allowed.

    

   
  		
  ddf25a5a40ff844698f8c7612503a27c551baa31
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbinstall/ui.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...