Summary

Don't query terminal colors if we're disabling color support.

Review Request #14250 — Created Nov. 15, 2024 and submitted Nov. 15, 2024, 6:45 p.m.

Information

Owner

chipx86

Repository

rbinstall

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

When starting up, we check the terminal background for light or dark
colors. This happens even if we've set no-color mode. That goes against
the intent of the workaround for terminal issues.

We no longer perform this check if color isn't allowed.

Testing Done

Ran in no-color mode and verified that a terminal query was never
performed.

Commits

Summary	ID
Don't query terminal colors if we're disabling color support. When starting up, we check the terminal background for light or dark colors. This happens even if we've set no-color mode. That goes against the intent of the workaround for terminal issues. We no longer perform this check if color isn't allowed.	ddf25a5a40ff844698f8c7612503a27c551baa31

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (97c41cd)