Summary

Move request_method_decorator into rbtools.api.resource.base

Review Request #14246 — Created Nov. 15, 2024 and submitted Feb. 10, 2025, 8:15 a.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This change moves the request_method_decorator into our base resource
definitions, since it's tightly tied to resources. It also renames it to
request_method for brevity. The old name will still work with a
deprecation warning.

Testing Done

Ran unit tests.

Commits

Summary	ID
Move request_method_decorator into rbtools.api.resource.base This change moves the `request_method_decorator` into our base resource definitions, since it's tightly tied to resources. It also renames it to `request_method` for brevity. The old name will still work with a deprecation warning. Testing Done: Ran unit tests.	f0fa5ba27765c8fe4a67a9db162090448ba74491

Issues

Description	From	Last Updated
Should we add a version changed that says we moved and renamed the function?	maubin	Dec. 12, 2024, 12:01 p.m.
Swap these (ordering issue).	chipx86	Jan. 23, 2025, 5:16 p.m.
This is missing Args and Returns. We should probably also have typing pass-through.	chipx86	Jan. 23, 2025, 5:16 p.m.
We should probably use @wraps or update_method at this point so all the other important properties get transferred over. We're …	chipx86	Jan. 23, 2025, 5:15 p.m.

flake8 passed.

JSHint passed.

rbtools/api/resource/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should we add a version changed that says we moved and renamed the function?
```

Commits:

	Summary	ID
	Move request_method_decorator into rbtools.api.resource.base This change moves the `request_method_decorator` into our base resource definitions, since it's tightly tied to resources. It also renames it to `request_method` for brevity. The old name will still work with a deprecation warning. Testing Done: Ran unit tests.	05de590e955924bc290b463a6d038bde03ebdd86
	Move request_method_decorator into rbtools.api.resource.base This change moves the `request_method_decorator` into our base resource definitions, since it's tightly tied to resources. It also renames it to `request_method` for brevity. The old name will still work with a deprecation warning. Testing Done: Ran unit tests.	a26da6b37ed6704692d984566d509dbdaf076dd8

Diff:

Revision 2 (+182 -104)

Show changes

	rbtools/api/decorators.py
	rbtools/api/resource/base.py
	rbtools/api/resource/diff.py
	rbtools/api/resource/diff_file_attachment.py
	rbtools/api/resource/draft_diff_commit.py
	rbtools/api/resource/file_attachment.py
	rbtools/api/resource/file_diff.py
	rbtools/api/resource/mixins.py
	5 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

rbtools/api/decorators.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Swap these (ordering issue).
```

rbtools/api/resource/base.py (Diff revision 2)

The issue has been resolved. Show all issues

This is missing Args and Returns.

We should probably also have typing pass-through.

david

Jan. 23, 2025, 5:17 p.m.

Typing for this happens in a later change.

rbtools/api/resource/base.py (Diff revision 2)

The issue has been dropped. Show all issues

We should probably use @wraps or update_method at this point so all the other important properties get transferred over. We're missing a lot.

david

Jan. 23, 2025, 5:17 p.m.
```
That happens in a later change.
```

Commits:

	Summary	ID
	Move request_method_decorator into rbtools.api.resource.base This change moves the `request_method_decorator` into our base resource definitions, since it's tightly tied to resources. It also renames it to `request_method` for brevity. The old name will still work with a deprecation warning. Testing Done: Ran unit tests.	a26da6b37ed6704692d984566d509dbdaf076dd8
	Move request_method_decorator into rbtools.api.resource.base This change moves the `request_method_decorator` into our base resource definitions, since it's tightly tied to resources. It also renames it to `request_method` for brevity. The old name will still work with a deprecation warning. Testing Done: Ran unit tests.	f0fa5ba27765c8fe4a67a9db162090448ba74491

Diff:

Revision 3 (+198 -104)

Show changes

	rbtools/api/decorators.py
	rbtools/api/resource/base.py
	rbtools/api/resource/diff.py
	rbtools/api/resource/diff_file_attachment.py
	rbtools/api/resource/draft_diff_commit.py
	rbtools/api/resource/file_attachment.py
	rbtools/api/resource/file_diff.py
	rbtools/api/resource/mixins.py
	5 more

Checks run (1 timed out)

JSHint timed out.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (de84d56)