Fish Trophy

david got a fish trophy!

Fish Trophy

Split up rbtools.api.resource.

Review Request #14241 — Created Nov. 11, 2024 and submitted — Latest diff uploaded

Information

RBTools
master

Reviewers

The resource definitions for RBTools are quite lengthy. While the bulk
of the current implementation all kind of needs to stick together, we
can split out individual resource-specific subclasses.

This change does not make any functional or other cleanup changes to the
code, just splits it up.

Ran unit tests.

Diff Revision 3 (Latest)

orig
1
2
3

Commits

First Last Summary ID Author
Split up rbtools.api.resource.
The resource definitions for RBTools are quite lengthy. While the bulk of the current implementation all kind of needs to stick together, we can split out individual resource-specific subclasses. The bulk of this is just splitting up code without making any other cleanup or functional changes. The only exception is DraftDiffResource, which was created for a mimetype that doesn't exist in Review Board (the server-side DraftDiffResource reports its mimetype as `diff` instead of `draft-diff`. This resource subclass has been removed and the old name is aliased to DiffResource. Testing Done: Ran unit tests.
4d0ca0d1eeef5997bb5e90d7cf79f7f2196f9e98 David Trowbridge
rbtools/api/resource/__init__.py
rbtools/api/resource.py
rbtools/api/resource/diff.py
rbtools/api/resource/diff_commit.py
rbtools/api/resource/diff_file_attachment.py
rbtools/api/resource/draft_diff_commit.py
rbtools/api/resource/draft_file_attachment.py
rbtools/api/resource/draft_screenshot.py
rbtools/api/resource/file_attachment.py
rbtools/api/resource/file_diff.py
rbtools/api/resource/mixins.py
rbtools/api/resource/review_request.py
rbtools/api/resource/root.py
rbtools/api/resource/screenshot.py
rbtools/api/resource/validate_diff.py
rbtools/api/resource/validate_diff_commit.py
rbtools/api/tests/test_resource.py
Loading...