
david got a fish trophy!

Split up rbtools.api.resource.
Review Request #14241 — Created Nov. 11, 2024 and submitted
The resource definitions for RBTools are quite lengthy. While the bulk
of the current implementation all kind of needs to stick together, we
can split out individual resource-specific subclasses.This change does not make any functional or other cleanup changes to the
code, just splits it up.
Ran unit tests.
Summary | ID |
---|---|
4d0ca0d1eeef5997bb5e90d7cf79f7f2196f9e98 |
Description | From | Last Updated |
---|---|---|
undefined name 'HttpRequest' Column: 19 Error code: F821 |
![]() |
|
blank line at end of file Column: 1 Error code: W391 |
![]() |
|
I know there's benefits to this syntax but I kind of don't like using it. It makes it a lot … |
|
|
The role name for these is :py:mod:. This comment applies to all the new modules. |
|
- Commits:
-
Summary ID 176a23a6f6688259b434deb2f1e832bd52121037 d7fb51dd07f8f940e383163bb9b891354865df26 - Diff:
-
Revision 2 (+1918 -1362)
Checks run (2 succeeded)
-
-
I know there's benefits to this syntax but I kind of don't like using it. It makes it a lot harder to search the codebase for certain imports (which I've done a lot while working on projects) and to order imports alongside non-relative imports.
Ages ago, I remember this topic coming up with contributed patches and we decided the benefits of the full class name outweighed the shorter line lengths. I think that's still the right call.
-
- Commits:
-
Summary ID d7fb51dd07f8f940e383163bb9b891354865df26 4d0ca0d1eeef5997bb5e90d7cf79f7f2196f9e98 - Diff:
-
Revision 3 (+1884 -1362)