david got a fish trophy!

Summary

Split up rbtools.api.resource.

Review Request #14241 — Created Nov. 11, 2024 and updated Nov. 11, 2024, 1:43 p.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

The resource definitions for RBTools are quite lengthy. While the bulk
of the current implementation all kind of needs to stick together, we
can split out individual resource-specific subclasses.

This change does not make any functional or other cleanup changes to the
code, just splits it up.

Testing Done

Ran unit tests.

Commits

Summary	ID
Split up rbtools.api.resource. The resource definitions for RBTools are quite lengthy. While the bulk of the current implementation all kind of needs to stick together, we can split out individual resource-specific subclasses. This change does not make any functional or other cleanup changes to the code, just splits it up. Testing Done: Ran unit tests.	d7fb51dd07f8f940e383163bb9b891354865df26

Issues

Description	From	Last Updated
undefined name 'HttpRequest' Column: 19 Error code: F821	reviewbot	Nov. 11, 2024, 1:43 p.m.
blank line at end of file Column: 1 Error code: W391	reviewbot	Nov. 11, 2024, 1:43 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/api/resource/draft_diff_commit.py (Diff revision 1)
The issue has been dropped. Show all issues
```
undefined name 'HttpRequest'

Column: 19
Error code: F821
```
rbtools/api/resource/root.py (Diff revision 1)
The issue has been dropped. Show all issues
```
blank line at end of file

Column: 1
Error code: W391
```

Commits:

	Summary	ID
	Split up rbtools.api.resource. The resource definitions for RBTools are quite lengthy. While the bulk of the current implementation all kind of needs to stick together, we can split out individual resource-specific subclasses. This change does not make any functional or other cleanup changes to the code, just splits it up. Testing Done: Ran unit tests.	176a23a6f6688259b434deb2f1e832bd52121037
	Split up rbtools.api.resource. The resource definitions for RBTools are quite lengthy. While the bulk of the current implementation all kind of needs to stick together, we can split out individual resource-specific subclasses. This change does not make any functional or other cleanup changes to the code, just splits it up. Testing Done: Ran unit tests.	d7fb51dd07f8f940e383163bb9b891354865df26

Diff:

Revision 2 (+1918 -1362)

Show changes

	rbtools/api/resource/__init__.py
	rbtools/api/resource.py
	rbtools/api/resource/diff.py
	rbtools/api/resource/diff_commit.py
	rbtools/api/resource/diff_file_attachment.py
	rbtools/api/resource/draft_diff.py
	rbtools/api/resource/draft_diff_commit.py
	rbtools/api/resource/draft_file_attachment.py
	10 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.