• 
      

    Allow mobile taps on region comments to open the comment dialog.

    Review Request #14187 — Created Sept. 25, 2024 and submitted — Latest diff uploaded

    Information

    Review Board
    release-7.x

    Reviewers

    On mobile, tapping on region comments doesn't open the comment dialog. This
    happens because touch events are being swallowed by the _onMouseDown
    handler, which doesn't handle clicks. Now we explicitly handle touchend
    events with the onClick handler which will bubble up the event to open
    the comment dialog. And the comment dialog doesn't open upon resizing or
    moving the comment, which matches desktop behaviour.

    I also made sure that our text based comments don't have this problem.

    Tested the following on mobile and desktop:
    - Creating new comments
    - Moving, resizing and clicking on existing draft comments
    - Trying to move/resize existing published comments.
    - Clicking on existing published comments.

    Commits

    Files