Allow mobile taps on region comments to open the comment dialog.

Review Request #14187 — Created Sept. 25, 2024 and updated

Information

Review Board
release-7.x

Reviewers

On mobile, tapping on region comments doesn't open the comment dialog. This
happens because touch events are being swallowed by the _onMouseDown
handler, which doesn't handle clicks. Now we explicitly handle touchend
events with the onClick handler which will bubble up the event to open
the comment dialog. And the comment dialog doesn't open upon resizing or
moving the comment, which matches desktop behaviour.

I also made sure that our text based comments don't have this problem.

Tested the following on mobile and desktop:
- Creating new comments
- Moving, resizing and clicking on existing draft comments
- Trying to move/resize existing published comments.
- Clicking on existing published comments.

Summary ID
Allow mobile taps on region comments to open the comment dialog.
On mobile, tapping on region comments doesn't open the comment dialog. This happens because touch events are being swallowed by the `_onMouseDown` handler, which doesn't handle clicks. Now we explicitly handle `touchend` events with the `onClick` handler which will bubble up the event to open the comment dialog.
bb1d4b908e7ddbeed69d70127a031249b2acda76
Checks run (2 succeeded)
flake8 passed.
JSHint passed.
david
  1. Ship It!
  2.