Override link colors inside alerts.

Review Request #14179 — Created Sept. 24, 2024 and updated

Information

Ink
master

Reviewers

Alerts show with light background colors even in dark mode. This change
makes it so links inside of alerts (other than type="standard") always
use the fg-on-light colors.

Added a link to the content in the alert story and flipped through all
the different type options for both light and dark mode. Saw that the
link was now legible.

Summary ID
Override link colors inside alerts.
Alerts show with light background colors even in dark mode. This change makes it so links inside of alerts (other than type="standard") always use the fg-on-light colors. Testing Done: Added a link to the content in the alert story and flipped through all the different type options for both light and dark mode. Saw that the link was now legible.
08264c0950cd50901d724677eae822f944065653

Description From Last Updated

Could we put these under the @__default__ rule instead of under each type? Also I notice that all the other …

maubinmaubin
Checks run (2 succeeded)
flake8 passed.
JSHint passed.
maubin
  1. 
      
  2. Show all issues

    Could we put these under the @__default__ rule instead of under each type? Also I notice that all the other variables start with and underscore --_ink-..., not sure if that's important or not.

    1. It can't go in @__default__ because the default ("standard") state is the one place where we do have a darker background.

      IIRC, the underscore prefixes are because those are internal to the alert component. In this case, we want to override the colors used by unrelated a rules, so we are explicitly changing the public variable within the scope of alert elements.

  3. 
      
maubin
  1. Ship It!
  2.