Enable system-matching light mode/dark mode by default.
Review Request #14167 — Created Sept. 12, 2024 and updated
Review Board 7.1 will now ship with system theme-matching on by default,
instead of light mode. This will enable dark mode if the system is set
to dark mode, and light mode otherwise.With this, dark mode is no longer in beta.
Unless a user has explicitly changed their theme, they'll use
system theme-matching as the new default. If they've explicitly opted
into either light or dark mode, they'll continue using that instead.
Verified that my default theme was matching my system.
Checked the Appearance tab and saw the options we want to let users
pick from: Default (system theme), Dark Mode, and Light Mode.All unit tests pass.
Summary | ID |
---|---|
f55b177c298c6d1edd11e42d24ab743e819dc274 |
Description | From | Last Updated |
---|---|---|
line too long (82 > 79 characters) Column: 80 Error code: E501 |
reviewbot | |
'reviewboard.themes.ui.default.LightUITheme' imported but unused Column: 1 Error code: F401 |
reviewbot | |
Hmm, what's up with this file? Something you forgot to commit earlier? |
david | |
Would it be more consistent to just say System theme rather than Use system theme? |
OfficeStapler |