Enable system-matching light mode/dark mode by default.

Review Request #14167 — Created Sept. 12, 2024 and updated

Information

Review Board
release-7.1.x

Reviewers

Review Board 7.1 will now ship with system theme-matching on by default,
instead of light mode. This will enable dark mode if the system is set
to dark mode, and light mode otherwise.

With this, dark mode is no longer in beta.

Unless a user has explicitly changed their theme, they'll use
system theme-matching as the new default. If they've explicitly opted
into either light or dark mode, they'll continue using that instead.

Verified that my default theme was matching my system.

Checked the Appearance tab and saw the options we want to let users
pick from: Default (system theme), Dark Mode, and Light Mode.

All unit tests pass.

Summary ID
Enable system-matching light mode/dark mode by default.
Review Board 7.1 will now ship with system theme-matching on by default, instead of light mode. This will enable dark mode if the system is set to dark mode, and light mode otherwise. With this, dark mode is no longer in beta. Unless a user has explicitly changed their theme, they'll use system theme-matching as the new default. If they've explicitly opted into either light or dark mode, they'll continue using that instead.
f55b177c298c6d1edd11e42d24ab743e819dc274
Description From Last Updated

line too long (82 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot

'reviewboard.themes.ui.default.LightUITheme' imported but unused Column: 1 Error code: F401

reviewbotreviewbot

Hmm, what's up with this file? Something you forgot to commit earlier?

daviddavid

Would it be more consistent to just say System theme rather than Use system theme?

OfficeStaplerOfficeStapler
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
Review request changed
Change Summary:

Removed an unused import.

Commits:
Summary ID
Enable system-matching light mode/dark mode by default.
Review Board 7.1 will now ship with system theme-matching on by default, instead of light mode. This will enable dark mode if the system is set to dark mode, and light mode otherwise. With this, dark mode is no longer in beta. Unless a user has explicitly changed their theme, they'll use system theme-matching as the new default. If they've explicitly opted into either light or dark mode, they'll continue using that instead.
1895ba880803a144289c31a5eb4400fd6ddda1f2
Enable system-matching light mode/dark mode by default.
Review Board 7.1 will now ship with system theme-matching on by default, instead of light mode. This will enable dark mode if the system is set to dark mode, and light mode otherwise. With this, dark mode is no longer in beta. Unless a user has explicitly changed their theme, they'll use system theme-matching as the new default. If they've explicitly opted into either light or dark mode, they'll continue using that instead.
f55b177c298c6d1edd11e42d24ab743e819dc274

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
david
  1. 
      
  2. reviewboard/themes/code/theme_reviewboard.py (Diff revision 2)
     
     
     
     
     
     
    Show all issues

    Hmm, what's up with this file? Something you forgot to commit earlier?

    1. Definitely not supposed to be there. I must have somehow merged in something from an in-progress branch...

  3. 
      
OfficeStapler
  1. 
      
  2. reviewboard/themes/ui/default.py (Diff revision 2)
     
     
    Show all issues

    Would it be more consistent to just say System theme rather than Use system theme?

    1. Probably would, thanks! Let me make that change and see how it reads in the UI.

  3.