Summary

Enable system-matching light mode/dark mode by default.

Review Request #14167 — Created Sept. 12, 2024 and submitted Nov. 13, 2024, 2:38 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Review Board 7.1 will now ship with system theme-matching on by default,
instead of light mode. This will enable dark mode if the system is set
to dark mode, and light mode otherwise.

With this, dark mode is no longer in beta.

Unless a user has explicitly changed their theme, they'll use
system theme-matching as the new default. If they've explicitly opted
into either light or dark mode, they'll continue using that instead.

Testing Done

Verified that my default theme was matching my system.
Checked the Appearance tab and saw the options we want to let users

pick from: Default (system theme), Dark Mode, and Light Mode.
All unit tests pass.

Commits

Summary	ID
Enable system-matching light mode/dark mode by default. Review Board 7.1 will now ship with system theme-matching on by default, instead of light mode. This will enable dark mode if the system is set to dark mode, and light mode otherwise. With this, dark mode is no longer in beta. Unless a user has explicitly changed their theme, they'll use system theme-matching as the new default. If they've explicitly opted into either light or dark mode, they'll continue using that instead.	129d37cee679cd2d6f94ab156a0bfe3d678152c7

Summary

Enable system-matching light mode/dark mode by default.

Review Board 7.1 will now ship with system theme-matching on by default, instead of light mode. This will enable dark mode if the system is set to dark mode, and light mode otherwise. With this, dark mode is no longer in beta. Unless a user has explicitly changed their theme, they'll use system theme-matching as the new default. If they've explicitly opted into either light or dark mode, they'll continue using that instead.

129d37cee679cd2d6f94ab156a0bfe3d678152c7

Issues

Description	From	Last Updated
line too long (82 > 79 characters) Column: 80 Error code: E501	reviewbot	Sept. 12, 2024, 4:42 p.m.
'reviewboard.themes.ui.default.LightUITheme' imported but unused Column: 1 Error code: F401	reviewbot	Sept. 12, 2024, 4:42 p.m.
Hmm, what's up with this file? Something you forgot to commit earlier?	david	Nov. 12, 2024, 3:37 a.m.
Would it be more consistent to just say System theme rather than Use system theme?	OfficeStapler	Nov. 12, 2024, 3:38 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/themes/tests/test_ui_theme_registry.py (Diff revision 1)
The issue has been resolved. Show all issues
```
line too long (82 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/themes/tests/test_ui_theme_registry.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'reviewboard.themes.ui.default.LightUITheme' imported but unused

Column: 1
Error code: F401
```

Change Summary:

Removed an unused import.

Commits:

	Summary	ID
	Enable system-matching light mode/dark mode by default. Review Board 7.1 will now ship with system theme-matching on by default, instead of light mode. This will enable dark mode if the system is set to dark mode, and light mode otherwise. With this, dark mode is no longer in beta. Unless a user has explicitly changed their theme, they'll use system theme-matching as the new default. If they've explicitly opted into either light or dark mode, they'll continue using that instead.	1895ba880803a144289c31a5eb4400fd6ddda1f2
	Enable system-matching light mode/dark mode by default. Review Board 7.1 will now ship with system theme-matching on by default, instead of light mode. This will enable dark mode if the system is set to dark mode, and light mode otherwise. With this, dark mode is no longer in beta. Unless a user has explicitly changed their theme, they'll use system theme-matching as the new default. If they've explicitly opted into either light or dark mode, they'll continue using that instead.	f55b177c298c6d1edd11e42d24ab743e819dc274

Diff:

Revision 2 (+306 -20)

Show changes

	reviewboard/accounts/tests/test_theme_form.py
	reviewboard/themes/code/theme_reviewboard.py
	reviewboard/themes/tests/test_ui_theme_registry.py
	reviewboard/themes/ui/default.py
	reviewboard/themes/ui/registry.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/themes/code/theme_reviewboard.py (Diff revision 2)

The issue has been resolved. Show all issues

Hmm, what's up with this file? Something you forgot to commit earlier?

chipx86 Sept. 16, 2024, 9:05 p.m.

Definitely not supposed to be there. I must have somehow merged in something from an in-progress branch...

reviewboard/themes/ui/default.py (Diff revision 2)

The issue has been resolved. Show all issues

Would it be more consistent to just say System theme rather than Use system theme?

chipx86 Sept. 16, 2024, 9:05 p.m.

Probably would, thanks! Let me make that change and see how it reads in the UI.

Change Summary:


Removed a file not part of this change.
Changed the system theme option name from "Use system theme" to "System theme".

Commits:

	Summary	ID
	Enable system-matching light mode/dark mode by default. Review Board 7.1 will now ship with system theme-matching on by default, instead of light mode. This will enable dark mode if the system is set to dark mode, and light mode otherwise. With this, dark mode is no longer in beta. Unless a user has explicitly changed their theme, they'll use system theme-matching as the new default. If they've explicitly opted into either light or dark mode, they'll continue using that instead.	f55b177c298c6d1edd11e42d24ab743e819dc274
	Enable system-matching light mode/dark mode by default. Review Board 7.1 will now ship with system theme-matching on by default, instead of light mode. This will enable dark mode if the system is set to dark mode, and light mode otherwise. With this, dark mode is no longer in beta. Unless a user has explicitly changed their theme, they'll use system theme-matching as the new default. If they've explicitly opted into either light or dark mode, they'll continue using that instead.	129d37cee679cd2d6f94ab156a0bfe3d678152c7

Diff:

Revision 3 (+32 -20)

Show changes

	reviewboard/accounts/tests/test_theme_form.py
	reviewboard/themes/tests/test_ui_theme_registry.py
	reviewboard/themes/ui/default.py
	reviewboard/themes/ui/registry.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (066c995)