Add dark mode styles for related object selector and fix table mode.

Review Request #14148 — Created Sept. 6, 2024 and submitted

Information

Djblets
release-5.x

Reviewers

This change adds dark mode styling (and generally overrides the default
Selectize view) for the related object selector. This isn't something
that's currently visible in Review Board, since the admin interface is
always in light mode, but it helps in RBCommons or other projects using
Djblets.

Also, I hadn't noticed that the option rendering change to allow
subclasses to use a table for the selected options broke the selectize
drop-down. I've changed it so there are now separate functions for the
drop-down and selected options (the default implementation of the former
just calling the former), so that we can provide a separate layout for
the drop-down and the selected items.

  • Verified that both the drop-down and selected items lists looked
    correct for both <table> and <li> based selectors.
  • Verified that the selectors looked good in both light and dark modes.
Summary ID
Add dark mode styles for related object selector and fix table mode.
This change adds dark mode styling (and generally overrides the default Selectize view) for the related object selector. This isn't something that's currently visible in Review Board, since the admin interface is always in light mode, but it helps in RBCommons or other projects using Djblets. Also, I hadn't noticed that the option rendering change to allow subclasses to use a table for the selected options broke the selectize drop-down. I've changed it so there are now separate functions for the drop-down and selected options (the default implementation of the former just calling the former), so that we can provide a separate layout for the drop-down and the selected items. Testing Done: - Verified that both the drop-down and selected items lists looked correct for both <table> and <li> based selectors. - Verified that the selectors looked good in both light and dark modes.
e9a544bc28fe08a6b65187cdf42b057281b0a71e

Description From Last Updated

The extra border-radius should be removed.

chipx86chipx86

We should just use background: completely here, let Ink totally control the background element. There's no guarantee it's a color.

chipx86chipx86

Same here.

chipx86chipx86
maubin
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. Show all issues

    The extra border-radius should be removed.

  3. Show all issues

    We should just use background: completely here, let Ink totally control the background element. There's no guarantee it's a color.

  4. Show all issues

    Same here.

  5. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-5.x (8ba4d82)