Summary

Add dark mode styles for related object selector and fix table mode.

Review Request #14148 — Created Sept. 6, 2024 and submitted Sept. 16, 2024, 8:45 a.m.

Information

Owner

david

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

Also, I hadn't noticed that the option rendering change to allow
subclasses to use a table for the selected options broke the selectize
drop-down. I've changed it so there are now separate functions for the
drop-down and selected options (the default implementation of the former
just calling the former), so that we can provide a separate layout for
the drop-down and the selected items.

Testing Done


Verified that both the drop-down and selected items lists looked

  correct for both <table> and <li> based selectors.
Verified that the selectors looked good in both light and dark modes.

Commits

Summary	ID
Add dark mode styles for related object selector and fix table mode. This change adds dark mode styling (and generally overrides the default Selectize view) for the related object selector. This isn't something that's currently visible in Review Board, since the admin interface is always in light mode, but it helps in RBCommons or other projects using Djblets. Also, I hadn't noticed that the option rendering change to allow subclasses to use a table for the selected options broke the selectize drop-down. I've changed it so there are now separate functions for the drop-down and selected options (the default implementation of the former just calling the former), so that we can provide a separate layout for the drop-down and the selected items. Testing Done: - Verified that both the drop-down and selected items lists looked correct for both <table> and <li> based selectors. - Verified that the selectors looked good in both light and dark modes.	e9a544bc28fe08a6b65187cdf42b057281b0a71e

Summary

Add dark mode styles for related object selector and fix table mode.

This change adds dark mode styling (and generally overrides the default Selectize view) for the related object selector. This isn't something that's currently visible in Review Board, since the admin interface is always in light mode, but it helps in RBCommons or other projects using Djblets. Also, I hadn't noticed that the option rendering change to allow subclasses to use a table for the selected options broke the selectize drop-down. I've changed it so there are now separate functions for the drop-down and selected options (the default implementation of the former just calling the former), so that we can provide a separate layout for the drop-down and the selected items. Testing Done: - Verified that both the drop-down and selected items lists looked correct for both <table> and <li> based selectors. - Verified that the selectors looked good in both light and dark modes.

e9a544bc28fe08a6b65187cdf42b057281b0a71e

Files

Issues

Description	From	Last Updated
The extra border-radius should be removed.	chipx86	Sept. 10, 2024, 10:29 a.m.
We should just use background: completely here, let Ink totally control the background element. There's no guarantee it's a color.	chipx86	Sept. 10, 2024, 10:29 a.m.
Same here.	chipx86	Sept. 10, 2024, 10:29 a.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

djblets/static/djblets/css/ui/related-object-selector.less (Diff revision 1)
The issue has been resolved. Show all issues
```
The extra border-radius should be removed.
```

djblets/static/djblets/css/ui/related-object-selector.less (Diff revision 1)

The issue has been resolved. Show all issues

We should just use background: completely here, let Ink totally control the background element. There's no guarantee it's a color.

djblets/static/djblets/css/ui/related-object-selector.less (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```

Commits:

	Summary	ID
	Add dark mode styles for related object selector and fix table mode. This change adds dark mode styling (and generally overrides the default Selectize view) for the related object selector. This isn't something that's currently visible in Review Board, since the admin interface is always in light mode, but it helps in RBCommons or other projects using Djblets. Also, I hadn't noticed that the option rendering change to allow subclasses to use a table for the selected options broke the selectize drop-down. I've changed it so there are now separate functions for the drop-down and selected options (the default implementation of the former just calling the former), so that we can provide a separate layout for the drop-down and the selected items. Testing Done: - Verified that both the drop-down and selected items lists looked correct for both <table> and <li> based selectors. - Verified that the selectors looked good in both light and dark modes.	fb5aa6bc4b56e73dea28a690bbaebdf2ac14420c
	Add dark mode styles for related object selector and fix table mode. This change adds dark mode styling (and generally overrides the default Selectize view) for the related object selector. This isn't something that's currently visible in Review Board, since the admin interface is always in light mode, but it helps in RBCommons or other projects using Djblets. Also, I hadn't noticed that the option rendering change to allow subclasses to use a table for the selected options broke the selectize drop-down. I've changed it so there are now separate functions for the drop-down and selected options (the default implementation of the former just calling the former), so that we can provide a separate layout for the drop-down and the selected items. Testing Done: - Verified that both the drop-down and selected items lists looked correct for both <table> and <li> based selectors. - Verified that the selectors looked good in both light and dark modes.	e9a544bc28fe08a6b65187cdf42b057281b0a71e

Diff:

Revision 2 (+120 -40)

Show changes

	djblets/static/djblets/css/ui/related-object-selector.less
	djblets/static/djblets/js/admin/views/relatedObjectSelectorView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.x (8ba4d82)